[tests] fixup dbcrash interaction with add_nodes() #11230

pull jnewbery wants to merge 1 commits into bitcoin:master from jnewbery:fixup_dbcrash changing 1 files +1 −1

jnewbery commented at 3:47 PM on September 4, 2017: member

Another conflict with #11121. Apologies - this is entirely my fault. I didn't run the extended test suite after rebasing on master. @MarcoFalke @sdaftuar
[tests] fixup dbcrash interaction with add_nodes() 8fdb6f9126
in test/functional/dbcrash.py:67 in 8fdb6f9126
```
  63 | @@ -64,7 +64,7 @@ def set_test_params(self):
  64 |  
  65 |      def setup_network(self):
  66 |          # Need a bit of extra time for the nodes to start up for this test
  67 | -        self.add_nodes(self.num_nodes, timewait=90)
  68 | +        self.add_nodes(self.num_nodes, extra_args=self.extra_args, timewait=90)
```
MarcoFalke commented at 4:08 PM on September 4, 2017:

We might as well get rid of passing member variables to methods.

jnewbery commented at 5:34 PM on September 12, 2017:

Agree, but I haven't looked into how big a change that would be (I'd need to look at all calls to add_nodes() to make sure they're not calling this method with no extra_args method and expecting the node to be started with any extra_args equal to [])
MarcoFalke commented at 4:08 PM on September 4, 2017: member

utACK 8fdb6f9126fe1e13b60de11fd34c204247679ef4
fanquake added the label Tests on Sep 5, 2017
sdaftuar commented at 12:18 PM on September 7, 2017: member

ACK, this fixes dbcrash.py now
MarcoFalke merged this on Sep 12, 2017
MarcoFalke closed this on Sep 12, 2017
MarcoFalke referenced this in commit b37cab65c6 on Sep 12, 2017
MarcoFalke referenced this in commit 4cf047497e on Oct 3, 2017
MarcoFalke referenced this in commit d8dd8e7356 on Oct 3, 2017
codablock referenced this in commit 797b474608 on Sep 24, 2019
barrystyle referenced this in commit 58b41761c4 on Jan 22, 2020
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#11121 TestNode tidyups