Add != to Base58 class #11253

pull JeremyRubin wants to merge 1 commits into bitcoin:master from JeremyRubin:add_neq_ctxdest changing 1 files +1 −0

JeremyRubin commented at 12:47 AM on September 6, 2017: contributor

It seems pretty frequently people hit confusion with lack of autogeneration of '!=' operations for Bas58, so this PR adds it. Should lead to fewer people getting caught on this one (I hope).

See: #11117 See: https://github.com/bitcoin/bitcoin/pull/9991
Add != to Base58 class 3dc0e864af
promag commented at 12:56 AM on September 6, 2017: member

Does this allows CTxDestination != CTxDestination?
kallewoof commented at 3:52 AM on September 6, 2017: member

utACK 3dc0e86
JeremyRubin commented at 6:34 AM on September 6, 2017: contributor

@promag It should!
sipa commented at 6:36 AM on September 6, 2017: member

CTxDestination is not in any way related to CBase58Data.
JeremyRubin commented at 7:12 AM on September 6, 2017: contributor

Oops yeah you're right -- I think I just misread, I thought it/it's members inherited from CBase58Data.

Closed!
JeremyRubin closed this on Sep 6, 2017
DrahtBot locked this on Sep 8, 2021

Contributors