Missing script verification flags in libbitcoinconsensus-0.dll #11263

issue sipsorcery opened this issue on September 7, 2017

sipsorcery commented at 11:55 AM on September 7, 2017: member

Is it intended that the the test set in src/test/data/script_tests.json should be able to be successfully executed against libbitcoinconsensus-0.dll?

After building from source on Windows the list of flags available in the bitcoinconsensus.h header are missing several of the script verification flags that are using in the JSON tests file, for example STRICTENC, CLEANSTACK, DISCOURAGE_UPGRADABLE_NOPS and others.

The full list looks like it's in src/script/interpreter.h. Are some not included in libbitcoinconsensus for a reason?
laanwj added the label Consensus on Sep 7, 2017
laanwj commented at 9:44 PM on September 7, 2017: member

The full list looks like it's in src/script/interpreter.h. Are some not included in libbitcoinconsensus for a reason?

Good question. But yes, that is intentional. Only the ones in consensus.h are consensus flags, and exposed on the interface, the other ones are internal to Bitcoin Core (and can change meaning from release to release, or even disappear). See #8976.
sipsorcery commented at 9:48 PM on September 7, 2017: member

Thx.
sipsorcery closed this on Sep 7, 2017
DrahtBot locked this on Sep 8, 2021

Contributors

Labels