Make sure ~/.bitcoin doesn’t exist before build #11297

1. 
   meshcollider commented at 4:29 am on September 10, 2017: contributor

   We’ve been getting some random travis failures since #11260 was merged, because the ~/.bitcoin directory exists after tests are run. Not sure exactly what’s causing it, but this PR ensures the directory doesn’t exist before running the build and tests, to see if this fixes the issue.

   Edit: travis has been run on this merge twice, and all tests passed both times, so either this fixes the issue or it just got lucky

2. Make sure ~/.bitcoin doesn't exist before build b73628d5a8
3. fanquake added the label Tests on Sep 10, 2017
4. 
   sipa commented at 6:57 pm on September 10, 2017: member

   utACK b73628d5a8e259a7f1fee5c4a245b463990f05a5. It survived 2 full Travis runs, and fixed the same issue occurring in #11167.
5. 
   laanwj commented at 10:35 pm on September 10, 2017: member

   If this is what I think it is, that PRs that were built by travis and cached before #11210 was merged have a ~/.bitcoin in their cache, it can also be solved by wiping the Travis caches.

   Edit: had to wipe the entire travis cache to test this - the Travis interface made it impossible to select individual PRs beyond 11111 or so. So I wiped all the cache and started a new build for the branches. Builds will be slow until master finishes rebuilding.

6. 
   meshcollider commented at 11:12 pm on September 10, 2017: contributor

   @laanwj does Travis cache data only from builds which pass all tests?
7. 
   laanwj commented at 11:34 pm on September 10, 2017: member

   @MeshCollider Yes
8. 
   meshcollider commented at 1:00 am on September 11, 2017: contributor

   @laanwj In that case this should never be an issue again right, because there should be no way for the directory to ever be cached, so we can close this
9. meshcollider closed this on Sep 11, 2017

   ---

10. 
    laanwj commented at 2:17 am on September 11, 2017: member

    I hope so! I’m not sure this is actually the issue, but it seemed likely. I do not understand where a .bitcoin directory would come from otherwise. We still might merge this though for symmetry, I don’t know.
11. meshcollider reopened this on Sep 11, 2017

    ---

12. 
    laanwj commented at 3:41 am on September 11, 2017: member

    I don’t think this was solved, I started #11289 a few times and it’s still failing. Reopening.
13. 
    MarcoFalke commented at 6:00 am on September 11, 2017: member

    Going to merge this, so we gain some air to breathe. But I can’t see how this dir was created at that point.
14. MarcoFalke merged this on Sep 11, 2017
15. MarcoFalke closed this on Sep 11, 2017

    ---

16. MarcoFalke referenced this in commit 16e41844e7 on Sep 11, 2017
17. 
    meshcollider commented at 6:57 am on September 11, 2017: contributor

    #11289 is passing now :+1:
18. 
    laanwj commented at 7:28 pm on September 11, 2017: member

    Great! I think this is good for a temporary workaround.

    There’s no chance that travis.yml will be executed on user’s account, otherwise this would be terribly dangerous.

19. meshcollider deleted the branch on Sep 11, 2017
20. DrahtBot locked this on Sep 8, 2021

Contributors
meshcollider sipa laanwj MarcoFalke

Labels
Tests