add m_added_nodes to connman options #11301

pull benma wants to merge 2 commits into bitcoin:master from benma:addnode changing 3 files +5 −8

benma commented at 2:24 PM on September 11, 2017: none

No description provided.
add m_added_nodes to connman options 605918272c

remove unused IsArgSet check

Forgotten in 506b700dcb5dd5a7c1d8ffa7c77043a93e4e10de

35e5c2269c

fanquake added the label Refactoring on Sep 11, 2017
dcousens approved
jimpo commented at 8:59 PM on September 11, 2017: contributor

utACK 35e5c22
sipa assigned theuni on Sep 11, 2017
sipa commented at 12:13 AM on September 12, 2017: member

Concept ACK, but I'd like @theuni's review.
jnewbery commented at 8:30 PM on September 14, 2017: member

slightly tested ACk 35e5c2269c9a9dc71e4141d15837683d5b3363a1
theuni approved
theuni commented at 6:13 PM on September 15, 2017: member

utACK 35e5c2269c9a9dc71e4141d15837683d5b3363a1

Though thread sanitizers may complain about the missing lock.

As a follow-up, mind moving Init() out of the header and into the cpp so that we can add more logic as necessary there? In this case, adding back the lock.
benma commented at 9:53 PM on September 22, 2017: none

Ready for merge?
sipa merged this on Sep 22, 2017
sipa closed this on Sep 22, 2017
sipa referenced this in commit 8776787108 on Sep 22, 2017
PastaPastaPasta referenced this in commit a23fae31b5 on Dec 22, 2019
PastaPastaPasta referenced this in commit e838807120 on Jan 2, 2020
PastaPastaPasta referenced this in commit 7098fa50c0 on Jan 4, 2020
PastaPastaPasta referenced this in commit 504eda873c on Jan 12, 2020
PastaPastaPasta referenced this in commit ddfb8a3a90 on Jan 12, 2020
PastaPastaPasta referenced this in commit 2eb0ac14ce on Jan 12, 2020
PastaPastaPasta referenced this in commit 3ba12f24a1 on Jan 12, 2020
ckti referenced this in commit 4b44c64268 on Mar 28, 2021
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels