Refactor: Move core files from src root to src/core and improve inclu… #11306

pull danra wants to merge 1 commits into bitcoin:master from danra:refactor/core-files changing 327 files +1157 −1051
  1. danra commented at 10:25 AM on September 12, 2017: contributor

    …de paths

    Advantages of moving the files under src into src/core:

    • Cleans up the root src
    • Allows for clearer management of includes - when an include is listed with no path prepended, there is no longer a dillema whether the included file is from the same folder as the including file, or just from the root src folder. This means:
      • Conflict resolution is cleaner in case a file of the same name exists both in the core folder and in the same folder as the including file - previously, to include the core file one had to either use a relative include path (../) or a brackets-system include. Now the core/ prefix can be used for cleaner disambiguation.
      • Files from the same folder can be included with no prefix with clear semantics, since files with no prefix are no longer maybe from the root src folder.
  2. Refactor: Move core files from src root to src/core and improve include paths
    Advantages of moving the files under src into src/core:
    - Cleans up the root src
    - Allows for clearer management of includes - when an include is listed with no path prepended, there is no longer a dillema whether the included file is from the same folder as the including file, or just from the root src folder. This means:
       - Conflict resolution is cleaner in case a file of the same name exists both in the core folder and in the same folder as the including file - previously, to include the core file one had to either use a relative include path (../) or a brackets-system include. Now the core/ prefix can be used for cleaner disambiguation.
       - Files from the same folder can be included with no prefix with clear semantics, since files with no prefix are no longer maybe from the root src folder.
    2b5b04b2a5
  3. fanquake added the label Refactoring on Sep 12, 2017
  4. promag commented at 3:02 PM on September 12, 2017: member

    At the moment NACK. There was a similar discussion regarding moving tests into subdirs..

  5. achow101 commented at 3:57 PM on September 12, 2017: member

    NACK. Large refactors like this shouldn't really be done as they will break a lot of unmerged pull requests.

  6. laanwj commented at 4:22 PM on September 20, 2017: member

    I'd prefer to do this in the longer term - move groups of files to a directory that makes sense for them. Moving everything that is now in the source root to a single subdirectory of src has some advantages, but IMO not enough for all the rebasing work this will cause.

    So NACK from me, sorry.

  7. danra commented at 6:15 PM on September 28, 2017: contributor

    Closing for lack of consensus. Thanks!

  8. danra closed this on Sep 28, 2017

  9. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-22 06:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me