crash when specifying path for -wallet= #11312

1. 
   dooglus commented at 9:31 pm on September 12, 2017: contributor

   Built against master branch 801dd40666d1e6009920ad3ff755c7bb993b2a62:

   $ ./bitcoind -wallet=/tmp/wallet.dat
   Error: Error loading wallet /tmp/wallet.dat. -wallet parameter must only specify a filename (not a path).
   Segmentation fault
   $ 
   

   It’s crashing here:

   Thread 1 "bitcoin-shutoff" received signal SIGSEGV, Segmentation fault.
   CConnman::Stop (this=0x0) at net.cpp:2405
   2405	    if (threadMessageHandler.joinable())
   (gdb) where
   [#0](/bitcoin-bitcoin/0/)  CConnman::Stop (this=0x0) at net.cpp:2405
   [#1](/bitcoin-bitcoin/1/)  0x00005555555a57fb in Shutdown () at init.cpp:197
   [#2](/bitcoin-bitcoin/2/)  0x00005555555997fb in AppInit (argc=<optimized out>, argv=<optimized out>) at bitcoind.cpp:183
   [#3](/bitcoin-bitcoin/3/)  0x0000555555599a39 in main (argc=0, argv=0x0) at bitcoind.cpp:195
   (gdb) 

2. 
   dooglus commented at 9:39 pm on September 12, 2017: contributor

   The error is being detected in VerifyWallets(), which is called before g_connman is initialized.

   Then in Shutdown() we run g_connman->Stop();, but g_connman isn’t initialized.

3. MarcoFalke closed this on Sep 14, 2017

   ---

4. MarcoFalke referenced this in commit 0f399a9ff2 on Sep 14, 2017
5. 
   theuni commented at 5:54 pm on September 18, 2017: member

   Post-merge ACK.

   I had observed a similar crash when testing the libevent changes and was carrying the patch here: https://github.com/bitcoin/bitcoin/pull/11227/commits/395d403516745782ac6bfc268bcda3ab9fca5a40. Didn’t realize this affected master as well, thanks for fixing!

6. codablock referenced this in commit 670e5df9fd on Sep 26, 2019
7. codablock referenced this in commit c35aa663bc on Sep 29, 2019
8. charlesrocket referenced this in commit ba872270f5 on Dec 15, 2019
9. barrystyle referenced this in commit 26821ec136 on Jan 22, 2020
10. MarcoFalke locked this on Sep 8, 2021

Contributors
dooglus theuni