Attempting to create new non-HD wallet ignores -usehd=0 without warning #11313

issue dooglus opened this issue on September 12, 2017

dooglus commented at 9:52 PM on September 12, 2017: contributor
Built against master branch 801dd40666d1e6009920ad3ff755c7bb993b2a62:

If I have no wallet.dat file and run:
```
bitcoind -usehd=0
```
A new wallet.dat file is created and an HD seed is assigned.

I see an error message in the source:
```
"Error loading %s: You can't disable HD on an already existing HD wallet or create new non-HD wallets."
```
but that doesn't get shown because fFirstRun is true, and so the code which checks for -usehd values doesn't run.

If it's no longer possible to create non-HD wallets, specifying -usehd=0 when creating a wallet should be an error, and not get silently ignored.
MarcoFalke commented at 9:54 PM on September 12, 2017: member

#11307
MarcoFalke added the label Wallet on Sep 12, 2017
dooglus commented at 10:11 PM on September 12, 2017: contributor

Thanks. I missed that one.

I was hoping to be able to create a pre-HD wallet to test #11085, but I see that is no longer an option. Any ideas how I can write a test that converts a pre-HD wallet to an HD wallet when -usehd has gone away?
achow101 commented at 10:53 PM on September 12, 2017: member

Any ideas how I can write a test that converts a pre-HD wallet to an HD wallet when -usehd has gone away?

You could make a small non-hd wallet file and test the upgrade for that.
laanwj closed this on Sep 19, 2017
laanwj referenced this in commit 4f7e37e26c on Sep 19, 2017
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#11307 wallet: Display non-HD error on first run