[tests] Check connectivity before sending in assumevalid.py #11345

pull jnewbery wants to merge 1 commits into bitcoin:master from jnewbery:assume_valid_improvement changing 1 files +2 −0

jnewbery commented at 6:40 PM on September 15, 2017: member

assumevalid.py would try to send over a closed P2P connection in a loop, hitting the following failure many times:

TestFramework.mininode (ERROR): Cannot send message. No connection to node!

The test still passed, but this is a lot of noise in the test log.

Just check that the connection is open before trying to send.

[tests] Check connectivity before sending in assumevalid.py

assumevalid.py would try to send over a closed P2P connection in a loop,
hitting the following failure many times:

TestFramework.mininode (ERROR): Cannot send message. No connection to node!

The test still passes, but this is a lot of noise in the test log.

Just check that the connection is open before trying to send.

e9e9391083

theuni commented at 6:54 PM on September 15, 2017: member

utACK e9e9391083721ca9733cc00a1907384f83b6435e
fanquake added the label Tests on Sep 15, 2017
MarcoFalke commented at 2:01 PM on September 18, 2017: member

utACK e9e9391
MarcoFalke merged this on Sep 18, 2017
MarcoFalke closed this on Sep 18, 2017
MarcoFalke referenced this in commit 44e1fd926c on Sep 18, 2017
MarcoFalke referenced this in commit f034089b2c on Oct 3, 2017
MarcoFalke referenced this in commit ce0f898005 on Oct 3, 2017
MarcoFalke referenced this in commit f9cf7b589f on Oct 3, 2017
codablock referenced this in commit b02b5d1acd on Jun 23, 2019
codablock referenced this in commit c7cafe5def on Jun 23, 2019
barrystyle referenced this in commit 182b8c9ce1 on Jan 22, 2020
DrahtBot locked this on Sep 8, 2021

Contributors

Labels