[Tests] Add Qt GUI tests to Overview and ReceiveCoin Page #11365

pull anditto wants to merge 1 commits into bitcoin:master from anditto:Adding-Qt-tests changing 1 files +71 −2

anditto commented at 6:39 AM on September 19, 2017: contributor

I've added some Qt wallet tests based on #9974, namely the input & buttons on ReceiveCoin.
fanquake added the label Tests on Sep 19, 2017
anditto force-pushed on Sep 19, 2017

in src/qt/test/wallettests.cpp:215 in 2f9b71f21c outdated

 210 | +    QLineEdit* labelInput = receiveCoinsDialog.findChild<QLineEdit*>("reqLabel");
 211 | +    labelInput->setText("TEST_LABEL_1");
 212 | +
 213 | +    // Amount input
 214 | +    BitcoinAmountField* amountInput = receiveCoinsDialog.findChild<BitcoinAmountField*>("reqAmount");
 215 | +    CAmount testAmount = 1.0;

kallewoof commented at 8:51 AM on September 19, 2017:

CAmounts are not floats; just use 1. Since you're not using it elsewhere you may want to just do setValue(1) below.

in src/qt/test/wallettests.cpp:233 in 2f9b71f21c outdated

 228 | +            QString paymentText = rlist->toPlainText();
 229 | +            QStringList paymentTextList = paymentText.split('\n');
 230 | +            QCOMPARE(paymentTextList.at(0), QString("Payment information"));
 231 | +            QVERIFY(paymentTextList.at(1).indexOf(QString("URI: bitcoin:")) != -1);
 232 | +            QVERIFY(paymentTextList.at(2).indexOf(QString("Address:")) != -1);
 233 | +            QCOMPARE(paymentTextList.at(3), QString("Amount: 0.00000001 BTC"));

kallewoof commented at 8:53 AM on September 19, 2017:

You may wanna use CURRENCY_UNIT instead of hard-coded BTC here. It's defined in policy/feerate.h.

kallewoof commented at 8:54 AM on September 19, 2017: member

utACK 2f9b71f21cd9a56d80b4517b8dab68c7160dc75e with some nits
[Tests] Add Qt GUI tests to Overview and ReceiveCoin Page 634e38ca71
anditto force-pushed on Sep 19, 2017
MarcoFalke merged this on Oct 2, 2017
MarcoFalke closed this on Oct 2, 2017
MarcoFalke referenced this in commit f199b8a33d on Oct 2, 2017
MarcoFalke commented at 7:24 PM on October 2, 2017: member

utACK 634e38ca7
anditto deleted the branch on Oct 10, 2017
PastaPastaPasta referenced this in commit d3c59cfea4 on Jan 17, 2020
PastaPastaPasta referenced this in commit 2c244c2cd3 on Jan 22, 2020
PastaPastaPasta referenced this in commit 41678a382d on Jan 22, 2020
PastaPastaPasta referenced this in commit 715426b41b on Jan 29, 2020
PastaPastaPasta referenced this in commit 6e829d96fe on Jan 29, 2020
PastaPastaPasta referenced this in commit 27a4f30f5f on Jan 31, 2020
PastaPastaPasta referenced this in commit 6d8738eb9e on Jan 31, 2020
ckti referenced this in commit bae751ab06 on Mar 28, 2021
gades referenced this in commit ba241e9bfb on Jun 30, 2021
DrahtBot locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#9974 Add basic Qt wallet test