net: remove more CConnman globals #11387

1. 
   theuni commented at 11:16 pm on September 22, 2017: member

   This continues some of the great work that @benma has been doing.

   More work towards a CConnman with no globals, so that we can test instances against themselves.

2. tor: pass in Tor control port rather than using globals

   Also, rather than adding to the existing unused parameters
   (threadGroup, scheduler), remove them and their header dependencies.

   81aebaf306
3. net: pass listen port into MapPort/Discover rather than using globals.

   This also allows the port-less AddLocal overload to be removed.

   0258734054
4. net: pass listen port into CConnman and remove global GetListenPort

   The global test is removed because it's no longer relevant. Overriding via the
   -port config option is tested extensively via python tests.

   6f2372d8ab
5. net: pass in default outgoing port 10c496c156
6. 
   theuni commented at 11:53 pm on September 22, 2017: member

   Grr, serves me right for building without Qt. Will fix.
7. fanquake added the label P2P on Sep 23, 2017
8. 
   theuni commented at 10:20 pm on September 25, 2017: member

   @jonasschnelli Any suggestion where to stick this? The qt build fails because the global accessor has been removed. I’d hate to add the global back just for qt.

   Is it possible to add a QSettings value from gArgs without it ending up stored in the config file?

9. 
   jonasschnelli commented at 9:53 pm on September 26, 2017: contributor

   @theuni: I don’t know whats the simples change. You could pass it into a GUI constant holder singleton (or pseudo global). Could be held in guiutil.cpp/h. Or just pass it around (to bitcoingui.cpp, etc., but I guess that will lead to a lot of code)
10. 
    benma commented at 8:47 am on September 27, 2017: none

    This seems to be the only option that changes operations on the fly. We could just not do that (setRestartRequired(true)).

    Otherwise, a clean option might be to register a callback in qt, called when non-restart settings are changed. Could hook up the dataChanged signal to a slot somewhere closer in qt to where the callback can be passed.

11. 
    jonasschnelli commented at 2:55 am on September 28, 2017: contributor

    Concept ACK
12. fanquake added this to the "In progress" column in a project

    ---

13. MarcoFalke added the label Needs rebase on Jun 6, 2018
14. 
    DrahtBot commented at 11:20 pm on November 8, 2018: member
15. DrahtBot added the label Up for grabs on Nov 8, 2018
16. DrahtBot closed this on Nov 8, 2018

    ---

17. 
    MarcoFalke commented at 7:36 pm on March 5, 2019: member

    Picked up in “net: remove more CConnman globals (theuni) #14856”
18. MarcoFalke removed the label Up for grabs on Mar 5, 2019
19. laanwj removed the label Needs rebase on Oct 24, 2019
20. MarcoFalke locked this on Dec 16, 2021

Contributors
theuni jonasschnelli benma DrahtBot MarcoFalke

Labels
P2P