[wallet] Remove segwit status check #11400

pull jl2012 wants to merge 1 commits into bitcoin:master from jl2012:postsegwitwallet changing 5 files +6 −13

jl2012 commented at 2:20 PM on September 25, 2017: contributor

addwitnessaddress returns an error if segwit is not activated. The test and the walletprematurewitness option becomes useless after segwit is activated
[wallet] Remove segwit status check b8016405d6
fanquake added the label Wallet on Sep 26, 2017

in test/functional/nulldummy.py:43 in b8016405d6

  39 | @@ -40,7 +40,7 @@ class NULLDUMMYTest(BitcoinTestFramework):
  40 |      def set_test_params(self):
  41 |          self.num_nodes = 1
  42 |          self.setup_clean_chain = True
  43 | -        self.extra_args = [['-whitelist=127.0.0.1', '-walletprematurewitness']]
  44 | +        self.extra_args = [['-whitelist=127.0.0.1']]

jnewbery commented at 5:39 PM on September 26, 2017:

the -whitelist argument isn't actually needed here. Just delete the line entirely.

jnewbery commented at 5:40 PM on September 26, 2017: member

concept ACK. One nit inline.
MarcoFalke commented at 7:08 PM on November 10, 2017: member

utACK b8016405d62a3592648267ca97312bae40ae72af

Needs rebase
MarcoFalke commented at 9:49 PM on November 17, 2017: member

I assume this requires that segwit is always active in mainnet, as the transactions would otherwise be rejected by your own node.
karan-ta commented at 9:34 AM on December 26, 2017: none

Hi,

I am using bin file of bitcoin core 15.1 and am getting this error when i try addwitnessaddress
sipa commented at 8:31 AM on December 27, 2017: member

Needs rebase.
fanquake added this to the "In progress" column in a project

promag commented at 2:14 PM on January 9, 2018: member

@jl2012 ping.
jnewbery commented at 2:45 PM on January 9, 2018: member

rebased branch here: https://github.com/jnewbery/bitcoin/tree/pr11400.1

Tested ACK https://github.com/jnewbery/bitcoin/commit/8a326f6de951fbd52bfdabb9fb434006ab539786
jnewbery commented at 3:24 PM on January 9, 2018: member

ah, I see that @laudaa has resurrected this in #12124. I think it's fine to merge that once the commit message there has been fixed.
jl2012 commented at 5:02 PM on January 9, 2018: contributor

Thanks @laudaa for #12124
jl2012 closed this on Jan 9, 2018
fanquake removed this from the "In progress" column in a project

DrahtBot locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#12124 [wallet] Remove segwit status check