Currently ./configure && make check
will look for python3, then python2. As long as we support python2 (and use it as fallback), make check
should run fine with both python2 and python3.
qa: Restore bitcoin-util-test py2 compatibility #11433
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:Mf1710-qaUtilPy2 changing 2 files +11 −4-
MarcoFalke commented at 9:27 am on October 1, 2017: member
-
qa: Restore bitcoin-util-test py2 compatibility fafff1220c
-
MarcoFalke added the label Tests on Oct 1, 2017
-
MarcoFalke added this to the milestone 0.15.1 on Oct 1, 2017
-
MarcoFalke added the label Needs backport on Oct 1, 2017
-
laanwj commented at 12:59 pm on October 2, 2017: memberutACK fafff12
-
jnewbery commented at 5:14 pm on October 3, 2017: member
Tested ACK fafff1220cf798e25f02cdd8affb70506dd366cc. Works with py2 and py3 for me.
Out of interest, what are the plans for deprecating py2 for
make && make check
? Obviously we can’t include any of the functional tests formake check
while we still support py2. -
MarcoFalke commented at 6:45 pm on October 3, 2017: memberI am not against deprecating py2, but we should do it properly such that
./configure
fails early and warns about it. Also it should be mentioned in the release notes. -
MarcoFalke merged this on Oct 3, 2017
-
MarcoFalke closed this on Oct 3, 2017
-
MarcoFalke referenced this in commit b4a509a3f8 on Oct 3, 2017
-
MarcoFalke deleted the branch on Oct 3, 2017
-
MarcoFalke referenced this in commit e169349f8c on Oct 4, 2017
-
MarcoFalke removed the label Needs backport on Oct 4, 2017
-
codablock referenced this in commit c8e17f1c37 on Sep 24, 2019
-
barrystyle referenced this in commit b2574a3e01 on Jan 22, 2020
-
DrahtBot locked this on Sep 8, 2021
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-17 15:12 UTC
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-17 15:12 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me