I get a compiler warning for this line here: https://github.com/bitcoin/bitcoin/blob/master/src/json/json_spirit_writer_template.h#L78
const wint_t unsigned_c( ( c >= 0 ) ? c : 256 + c );
I don't know how to fix this, so I at least wanted to point the devs to it.
I've seen this warning as well, however I've not fixed any warnings in json_spirit. I'm not sure we should do anything about it, as it's not our code.
Whose code is it and what is it used for?
it is used for serialising json in the json-rpc interface. that link you're talking about is not really an issue.
what happens is that the method can be instantiated using a template parameter. so there are different string type definitions creating that function. sometimes it has a 'char' type which is unsigned - sometimes not. I guess that is unicode (wint_t) and non-unicode strings (char).
If this does not need to get fixed or can't be fixed by us, shall I close this?
Closing this, as no further comments were added.