rpc: Update importprivkey named args documentation #11462

issue MarcoFalke opened this issue on October 7, 2017
  1. MarcoFalke commented at 8:43 AM on October 7, 2017: member

    The documentation for importprivkey refers to the first named argument with the wrong string:

    https://github.com/bitcoin/bitcoin/blob/7f11ef26085549664a911fe00807a199bbd1f041/src/wallet/rpcdump.cpp#L83-L86

    The correct string for the name is mentioned in src/wallet/rpcwallet.cpp. This should be easy to fix, thus tagging with "hacktoberfest".

    The fix could also update the calls to importprivkey in test/functional/importprunedfunds.py to use named args.

  2. MarcoFalke added the label Docs and Output on Oct 7, 2017
  3. MarcoFalke added the label hacktoberfest on Oct 7, 2017
  4. dusty-wil commented at 6:15 PM on October 7, 2017: contributor

    Hi @MarcoFalke , I can take a look at this! I'm new to python, but interested in learning

  5. MarcoFalke commented at 7:25 AM on October 8, 2017: member

    @dusty-wil Great to hear. Updating the python test code is optional, but a good way to prove the correctness of your patch. You could start by fixing the help text in the cpp file.

  6. dusty-wil commented at 8:26 PM on October 8, 2017: contributor

    Ok, sounds good! I'll be able to look in to this later this evening!

  7. dusty-wil referenced this in commit afc96d3fbe on Oct 9, 2017
  8. dusty-wil referenced this in commit 0e276d8c5a on Oct 9, 2017
  9. dusty-wil commented at 3:33 AM on October 9, 2017: contributor

    @MarcoFalke ok, I think I've got it, created the PR.

  10. promag commented at 8:42 AM on October 9, 2017: member

    IMO a fix should not do unrelated changes.

  11. dusty-wil referenced this in commit aa57590d7c on Oct 9, 2017
  12. MarcoFalke closed this on Oct 9, 2017

  13. MarcoFalke referenced this in commit 92eadc3950 on Oct 9, 2017
  14. MarcoFalke referenced this in commit 405e069d3b on Oct 9, 2017
  15. HashUnlimited referenced this in commit 024d605ff5 on Mar 12, 2018
  16. codablock referenced this in commit f8f55c25c8 on Sep 25, 2019
  17. barrystyle referenced this in commit 90eaca8ada on Jan 22, 2020
  18. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 15:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me