qa: Make tmpdir option an absolute path, misc cleanup #11472

1. 
   MarcoFalke commented at 10:06 pm on October 9, 2017: member

   This should fix issues with the multiwallet test and its symlinks when the tmpdir is a relative path.

   Rather than fixing os.symlink to work with paths relative to a directory descriptor, which does not work on Windows, normalize the path instead.

2. MarcoFalke added the label Tests on Oct 9, 2017
3. 
   laanwj commented at 7:02 am on October 10, 2017: member

   utACK https://github.com/bitcoin/bitcoin/pull/11472/commits/fa949d1bd6710358626eb70a47dfa101c0a60da2, storing paths as absolute is always a good precaution to prevent unexpected behavior.
4. 
   promag commented at 9:08 am on October 10, 2017: member

   utACK.

   Should the same applies to cachedir?

5. 
   laanwj commented at 2:45 pm on October 12, 2017: member

   Should the same applies to cachedir?

   I think that makes sense (not sure it’s in scope of this issue though).

6. 
   jnewbery commented at 9:40 pm on October 12, 2017: member

   Tested ACK fa949d1bd6710358626eb70a47dfa101c0a60da2.

   :+1: for the same treatment to cachedir

7. qa: Make tmpdir option an absolute path

   This should fix issues with the multiwallet test and symlinks
   when the tmpdir is a relative path.
   
   Rather than fixing os.symlink to work with paths relative to a
   directory descriptor, which does not work on Windows, normalize
   the path instead.

   fa9de370b1
8. qa: Remove never used return value of sync_with_ping fafa003970
9. MarcoFalke force-pushed on Oct 13, 2017
10. MarcoFalke renamed this:
    qa: Make tmpdir option an absolute path
    qa: Make tmpdir option an absolute path, misc cleanup
    on Oct 13, 2017
11. 
    promag commented at 9:04 pm on October 16, 2017: member

    re-utACK fafa003.
12. 
    meshcollider commented at 11:31 pm on October 16, 2017: contributor

    utACK https://github.com/bitcoin/bitcoin/commit/fafa0039708e15d1067be091b2bfc10195afa480
13. laanwj merged this on Oct 18, 2017
14. laanwj closed this on Oct 18, 2017

    ---

15. laanwj referenced this in commit 6759a24eaa on Oct 18, 2017
16. MarcoFalke deleted the branch on Oct 18, 2017
17. MarcoFalke referenced this in commit b0aabfd6f1 on Nov 1, 2017
18. MarcoFalke referenced this in commit 6e5c147c46 on Nov 1, 2017
19. MarcoFalke referenced this in commit f3457d0e83 on Nov 1, 2017
20. MarcoFalke referenced this in commit 41088795dd on Nov 1, 2017
21. codablock referenced this in commit 2a854188c7 on Sep 26, 2019
22. codablock referenced this in commit f18fa576b9 on Sep 29, 2019
23. barrystyle referenced this in commit 29635841f3 on Jan 22, 2020
24. DrahtBot locked this on Sep 8, 2021

Contributors
MarcoFalke laanwj promag jnewbery meshcollider

Labels
Tests