c2e8c8ac breaks tests #1148

1. 
   sipa commented at 1:30 AM on April 26, 2012: member

   $ ./test_bitcoin 
   Running 52 test cases...
   Disconnected 1.192.176.160:8333 for misbehavior (score=100)
   Disconnected 2.192.176.160:8333 for misbehavior (score=100)
   Disconnected 1.192.176.160:8333 for misbehavior (score=111)
   Disconnected 1.192.176.160:8333 for misbehavior (score=100)
   test/multisig_tests.cpp(83): error in "multisig_verify": check VerifyScript(s, a_and_b, txTo[0], 0, true, 0) failed
   test/multisig_tests.cpp(105): error in "multisig_verify": a|b: 0
   test/multisig_tests.cpp(105): error in "multisig_verify": a|b: 1
   test/multisig_tests.cpp(124): error in "multisig_verify": escrow 1: 0 1
   test/multisig_tests.cpp(124): error in "multisig_verify": escrow 1: 0 2
   test/multisig_tests.cpp(124): error in "multisig_verify": escrow 1: 1 2
   test/multisig_tests.cpp(291): error in "multisig_Sign": SignSignature 0
   test/multisig_tests.cpp(291): error in "multisig_Sign": SignSignature 1
   test/multisig_tests.cpp(291): error in "multisig_Sign": SignSignature 2
   test/script_P2SH_tests.cpp(190): error in "set": SignSignature 1
   test/script_P2SH_tests.cpp(190): error in "set": SignSignature 2
   test/script_P2SH_tests.cpp(190): error in "set": SignSignature 3
   test/script_P2SH_tests.cpp(298): error in "AreInputsStandard": check SignSignature(keystore, txFrom, txTo, 2) failed
   test/script_tests.cpp(244): error in "script_CHECKMULTISIG12": check VerifyScript(goodsig1, scriptPubKey12, txTo12, 0, true, 0) failed
   test/script_tests.cpp(249): error in "script_CHECKMULTISIG12": check VerifyScript(goodsig2, scriptPubKey12, txTo12, 0, true, 0) failed
   test/script_tests.cpp(280): error in "script_CHECKMULTISIG23": check VerifyScript(goodsig1, scriptPubKey23, txTo23, 0, true, 0) failed
   test/script_tests.cpp(285): error in "script_CHECKMULTISIG23": check VerifyScript(goodsig2, scriptPubKey23, txTo23, 0, true, 0) failed
   test/script_tests.cpp(290): error in "script_CHECKMULTISIG23": check VerifyScript(goodsig3, scriptPubKey23, txTo23, 0, true, 0) failed
   

2. 
   sipa commented at 1:33 AM on April 26, 2012: member

   Get github to link to the commit: c2e8c8ac

3. 
   sipa commented at 1:36 PM on April 26, 2012: member

   The specific commit that caused this is faf705a

4. 
   gavinandresen commented at 2:04 PM on April 26, 2012: contributor

   It breaks OP_CHECKMULTISIG, at least on my 64-bit Linux virtual machine:

   Exception thrown from this line in script.cpp: 946 int nKeysCount = CastToBigNum(stacktop(-i)).getint(); (gdb) p i $7 = 1 (gdb) p -i $8 = 4294967295

5. 
   gavinandresen commented at 2:19 PM on April 26, 2012: contributor

   Fixed by reverting i to signed.

6. gavinandresen closed this on Apr 26, 2012

   ---

7. lateminer referenced this in commit 3ad5e11b48 on Jan 22, 2019
8. MarcoFalke locked this on Sep 8, 2021

Milestone
0.6.1