[tests] Add uacomment tests #11486

pull mess110 wants to merge 1 commits into bitcoin:master from mess110:test_uacomment changing 2 files +36 −0

mess110 commented at 8:02 PM on October 11, 2017: contributor

Checks for setting the value, max length and reserved characters

[tests] Add uacomment tests

Checks for setting the value, max length and reserved characters

c5dfa90aab

mess110 force-pushed on Oct 11, 2017
fanquake added the label Tests on Oct 11, 2017
laanwj commented at 2:23 PM on October 12, 2017: member

utACK https://github.com/bitcoin/bitcoin/pull/11486/commits/c5dfa90aab53832c9ad339360d11d6635a26ba6b, thanks for adding tests!
promag commented at 4:32 PM on October 12, 2017: member

Nice. Missing one test with multiple -uacomment values.
mess110 commented at 4:52 PM on October 12, 2017: contributor

@promag by default test nodes have 1 uacomment set which I test here: https://github.com/bitcoin/bitcoin/pull/11486/files#diff-9bf941056cb812e87bf8826dd7a34952R18 and the following test checks for 2 uacomments (default + foo)

I can add another one if more people think it is needed, but for now, I think it is enough.

Thanks for the review
promag commented at 4:56 PM on October 12, 2017: member

Ahh yes, restart with extra args.

utACK c5dfa90 then.
achow101 commented at 6:05 PM on October 13, 2017: member

utACK c5dfa90aab53832c9ad339360d11d6635a26ba6b
laanwj merged this on Oct 18, 2017
laanwj closed this on Oct 18, 2017
laanwj referenced this in commit 2ca518deff on Oct 18, 2017
PastaPastaPasta referenced this in commit d6ccd49c49 on Dec 22, 2019
PastaPastaPasta referenced this in commit 5bc0573d91 on Jan 2, 2020
PastaPastaPasta referenced this in commit 759da70f70 on Jan 4, 2020
PastaPastaPasta referenced this in commit 97186f941c on Jan 12, 2020
PastaPastaPasta referenced this in commit 3237f7067a on Jan 12, 2020
PastaPastaPasta referenced this in commit c68d210703 on Jan 12, 2020
PastaPastaPasta referenced this in commit 62073c2057 on Jan 12, 2020
PastaPastaPasta referenced this in commit 8d408a8ce8 on Jan 12, 2020
PastaPastaPasta referenced this in commit 27ea6902a5 on Jan 12, 2020
PastaPastaPasta referenced this in commit 21514ceb50 on Jan 16, 2020
ckti referenced this in commit f9c786817c on Mar 28, 2021
gades referenced this in commit 1d545004c4 on Jun 30, 2021
DrahtBot locked this on Sep 8, 2021

Contributors

Labels