This gives a boost to the process as it doesn't make std::multimap lookups. Obviously there is a memory tradeoff which I didn't measured yet. However the weight of CheckBlockIndex goes from around 9% to 3% (measured in Instruments in regtest with 10000 blocks).
Improve CheckBlockIndex performance #11563
pull promag wants to merge 2 commits into bitcoin:master from promag:2017-10-improve-checkblockindex changing 1 files +20 −23-
promag commented at 12:50 AM on October 26, 2017: member
-
Validate genesis out of loop in CheckBlockIndex 7fe1e35c4d
- fanquake added the label Validation on Oct 26, 2017
-
Cache siblings on depth first search in CheckBlockIndex c13d38f433
- promag force-pushed on Oct 26, 2017
-
- fanquake requested review from sipa on Nov 9, 2017
-
promag commented at 7:14 PM on February 8, 2018: member
Needs benchmarking.
- promag closed this on Feb 8, 2018
- promag deleted the branch on Feb 8, 2018
- DrahtBot locked this on Sep 8, 2021
