potential problem with nodes ignoring getdata requests #1157

issue rebroad openend this issue on April 28, 2012
  1. rebroad commented at 1:50 pm on April 28, 2012: contributor

    Although some code has already been introduced for “misbehaving” nodes, I think this could be further extended.

    E.g. nodes ignoring getdata requests. So far, this can cause a node to wait 2 minutes before re-asking, but if enough nodes started ignoring getdata requests, this could possibly cause significant detriment to the network.

    I propose some code that allows nodes to learn the network speed they are operating on, e.g. average times between asking for a tx or a block and receiving one. Then it should be possible to introduce timeouts for nodes which are significantly taking longer than average, and mark them as suspicious (may be that they just have poor network connectivity). This can be particularly of significance when catching up with the blockchain.

    By learning network speeds, the node can determine whether to download blocks from a number of nodes at once, rather than just one at a time, and also whether to upload blocks to many nodes at once or just one at a time.

  2. laanwj added the label P2P on May 9, 2014
  3. rebroad commented at 3:34 pm on November 24, 2016: contributor
    Worth bearing in mind for this that nodes that are not up-to-date, i.e. still doing IBD can be very likely to in effect ignore all messages - often connections to core nodes in IBD can go without any data send or received for over 20 minutes causing a timeout disconnect.
  4. suprnurd referenced this in commit c2ec99ba8e on Dec 5, 2017
  5. lateminer referenced this in commit 5e99d27182 on Jan 22, 2019
  6. adamjonas commented at 2:11 pm on October 22, 2019: member
    Was this closed by #7079?
  7. MarcoFalke closed this on Oct 22, 2019

  8. lateminer referenced this in commit 04480012aa on Dec 25, 2019
  9. Bushstar referenced this in commit 1fa02a16c4 on Nov 11, 2020
  10. MarcoFalke locked this on Dec 16, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-17 00:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me