add a clear all button to the sign message page (addresses #943) #1166

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:signmessage_clear changing 3 files +25 −3

Diapolo commented at 11:14 PM on April 29, 2012: none

This needs a review from @laanwj, as I simply tried to figure out what I needed to add via some copy & paste from the source and trial and error. I hope I'm on track tough.

This addresses #943!
in src/qt/messagepage.cpp:None in fc6f24cd0a outdated
```
 104 | @@ -105,3 +105,10 @@ void MessagePage::on_signMessage_clicked()
 105 |      ui->signature->setText(QString::fromStdString(EncodeBase64(&vchSig[0], vchSig.size())));
 106 |      ui->signature->setFont(GUIUtil::bitcoinAddressFont());
 107 |  }
 108 | +
 109 | +void MessagePage::on_clearButton_clicked()
 110 | +{
 111 | +    ui->signFrom->clear();
 112 | +    ui->message->clear();
 113 | +    ui->signature->setText(tr("Click \"Sign Message\" to get signature"));
```
laanwj commented at 6:39 AM on May 1, 2012:

I'd prefer also doing ui->signature->clear(), then defining this help message as "Placeholder text" in the ui file. This has the same functionality, but also shades the help text in grey (and with the difference that the message isn't repeated twice in the code).

Diapolo commented at 9:47 AM on May 1, 2012:

I didn't know that clear() restores the default text, so yes your suggestion is much nicer. Will re-work this.
Diapolo commented at 9:55 AM on May 1, 2012: none

Updated to reflect laanwjs suggestion. After an ACK I will merge both commits.
laanwj commented at 6:04 AM on May 3, 2012: member

ACK
add a clear all button to the sign message page 65c2ad687f
Diapolo commented at 7:25 AM on May 3, 2012: none

Rebased to be a single commit, no further code-changes.
laanwj referenced this in commit 4c9183e8bb on May 5, 2012
laanwj merged this on May 5, 2012
laanwj closed this on May 5, 2012
coblee referenced this in commit a16da8b085 on Jul 17, 2012
suprnurd referenced this in commit 1b90d66ab6 on Dec 5, 2017
lateminer referenced this in commit e4040d6612 on Jan 22, 2019
lateminer referenced this in commit 4cc04b0ba6 on Dec 25, 2019
dexX7 referenced this in commit 4124354b4c on Sep 10, 2020
DrahtBot locked this on Sep 8, 2021

Contributors

Diapolo

laanwj

Linked (view graph)

#943 sign message window misses a "Clear all" button