DoS prevention: check for duplicate transactions earlier #1167

issue gavinandresen opened this issue on April 30, 2012
  1. gavinandresen commented at 2:59 PM on April 30, 2012: contributor

    If you include the same transaction in a block twice the block is rejected by ConnectInputs()... but that is only done after fetching transactions from disk, checking signatures, etc. And it doesn't trigger the DoS prevention code.

    There should be a check for duplicate transactions in CheckBlock(), so blocks with duplicate transactions are rejected early and trigger the DoS code.

  2. gavinandresen closed this on Apr 30, 2012

  3. luke-jr referenced this in commit ad5a4c7c47 on May 20, 2012
  4. luke-jr referenced this in commit 6a89317f62 on May 20, 2012
  5. coblee referenced this in commit 43080f2d9a on Jul 17, 2012
  6. suprnurd referenced this in commit ecdc160119 on Dec 5, 2017
  7. lateminer referenced this in commit 5220fc7dfe on Jan 22, 2019
  8. lateminer referenced this in commit fc4ffcf4af on Dec 25, 2019
  9. MarcoFalke locked this on Sep 8, 2021
Contributors
Labels

Milestone
0.6.1


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-02 15:16 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me