leveldb: Add filename to corruption errors #11674

1. 
   laanwj commented at 9:21 am on November 13, 2017: member

   (https://github.com/bitcoin-core/leveldb/pull/15 should go in first, but filing it here for review/visibility/easy testing, do not merge)

   When a leveldb corruption happens, report the filename of the file where corruptions happens. This will aid in diagnosing database corruption issues.

   Adds a GetName() to all the environment file classes to make it possible to report a filename downstream.

   Example:

   02017-11-13 09:35:25 LevelDB read failure: Corruption: block checksum mismatch: /.../.bitcoin/regtest/blocks/index/000042.ldb
   

   (travis is failing due to subtree merge, which is correct)

2. laanwj added the label Upstream on Nov 13, 2017
3. leveldb: Add filename to corruption errors

   When a corruption happens, report the filename of the file where corruptions happens.
   This will aid in diagnosing database corruption issues.
   
   Adds a GetName() to all the environment file classes to make it possible
   to report a filename downstream.

   47bc05c589
4. laanwj force-pushed on Nov 13, 2017
5. 
   meshcollider commented at 9:51 am on November 13, 2017: contributor

   Big concept ACK, from IRC messages
6. 
   jonasschnelli commented at 8:24 pm on November 13, 2017: contributor

   Nice! Concept ACK
7. 
   jtimon commented at 8:04 pm on November 16, 2017: contributor

   Concept ACK
8. 
   laanwj commented at 12:29 pm on November 30, 2017: member

   I’ve merged this upstream, so this will come back to the bitcoin repository eventually, after the next tree update. Closing.
9. laanwj closed this on Nov 30, 2017

   ---

10. sebrandon1 referenced this in commit aae64a21ba on Feb 22, 2018
11. jasonbcox referenced this in commit 707568ec56 on Sep 13, 2019
12. jonspock referenced this in commit 86c9c9d772 on Dec 22, 2019
13. proteanx referenced this in commit e4928f4a49 on Dec 23, 2019
14. DrahtBot locked this on Sep 8, 2021

Contributors
laanwj meshcollider jonasschnelli jtimon

Labels
Upstream