Fix for mismatched extern definition in wallet tests #11713

pull sipsorcery wants to merge 1 commits into bitcoin:master from sipsorcery:externfix changing 2 files +2 −2

sipsorcery commented at 8:00 AM on November 18, 2017: member

The extern declarations are using a raw pointer which doesn't match the source variable's std::unqiue_ptr.
Fix for mismatched extern definition in wallet test classes which was breaking msvc linking. f94c2ecb48
fanquake added the label Tests on Nov 18, 2017
sipa commented at 8:33 AM on November 18, 2017: member

Ouch. utACK
laanwj commented at 1:02 PM on November 18, 2017: member
Defined as:
```
src/wallet/test/wallet_test_fixture.cpp:std::unique_ptr<CWallet> pwalletMain;
```
Correct, good catch. Makes me wonder why this isn't simply a field on the test fixture.

Anyhow utACK https://github.com/bitcoin/bitcoin/pull/11713/commits/f94c2ecb48f2b3656f7412a010569eaf21fa83f5
laanwj merged this on Nov 18, 2017
laanwj closed this on Nov 18, 2017
laanwj referenced this in commit 49667a77e7 on Nov 18, 2017
laanwj referenced this in commit 45add2274c on Nov 18, 2017
laanwj referenced this in commit 088e551413 on Nov 18, 2017
laanwj referenced this in commit 49bd6590fe on Nov 18, 2017
laanwj referenced this in commit 9cdd2bcf67 on Nov 19, 2017
sipsorcery deleted the branch on Nov 21, 2017
HashUnlimited referenced this in commit 4f668cfc2e on Mar 13, 2018
PastaPastaPasta referenced this in commit 4cfa8baaf5 on Jan 17, 2020
PastaPastaPasta referenced this in commit bac0648880 on Jan 22, 2020
PastaPastaPasta referenced this in commit 658a98a69b on Jan 22, 2020
PastaPastaPasta referenced this in commit 9144aafbc4 on Jan 29, 2020
PastaPastaPasta referenced this in commit b07552bb11 on Jan 29, 2020
PastaPastaPasta referenced this in commit 27d325eaea on Jan 29, 2020
PastaPastaPasta referenced this in commit 152cf71e22 on Feb 13, 2020
PastaPastaPasta referenced this in commit 9b636ee799 on Feb 27, 2020
PastaPastaPasta referenced this in commit 6fc9f432be on Mar 14, 2020
PastaPastaPasta referenced this in commit bdb2f7e9dd on Mar 21, 2020
PastaPastaPasta referenced this in commit d94dd15de7 on Mar 24, 2020
ckti referenced this in commit 214d0edd04 on Mar 28, 2021
ckti referenced this in commit 21277153dc on Mar 28, 2021
random-zebra referenced this in commit 096a0f9640 on May 17, 2021
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#11718 tests: move pwalletMain to wallet test fixture