[qa] Net.py fails occasionally #11778

issue MarcoFalke openend this issue on November 27, 2017
  1. MarcoFalke commented at 9:29 pm on November 27, 2017: member

    In net.py we compare the exact number of bytes transmitted or received of two subsequently called rpcs. This fails occasionally. I hypothesise that this might be caused by cross-traffic that happens in between those rpcs, which are obviously not called atomically.

    If that is the case, we might be able to repeat the calls up to ${n} times and hope that cross-traffic does not happen in all ${n} cases.

    Relevant example log:

  2. MarcoFalke added the label Tests on Nov 27, 2017
  3. MarcoFalke renamed this:
    [qa] Net.py failes occasionally
    [qa] Net.py fails occasionally
    on Nov 27, 2017
  4. jnewbery commented at 9:03 pm on March 27, 2018: member

    Agree that your hypothesis is the most likely explanation here.

    Your fix seems reasonable. Will open a PR.

  5. MarcoFalke closed this on Mar 30, 2018

  6. MarcoFalke referenced this in commit 243c9bb79a on Mar 30, 2018
  7. codablock referenced this in commit cf632029b9 on Oct 22, 2019
  8. barrystyle referenced this in commit 66f64a20eb on Jan 22, 2020
  9. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-17 21:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me