in main.cpp, there is a section that adds to the "askfor" queue a block where AlreadyHave() returns true. Then later when the code retrieves the queue, it erases it without actioning it due to AlreadyHave() returning true.
Which bit of code is incorrect? The adding to the queue part, or the actioning the queue part?
You can make comments inside the actual code. I'm not sure which part you're talking about now.
ah.. good idea... using github? do I need to find the commit that added the code first?
(by the way, my bitcoin is still reporting 0.6.0rc4, even though I've merged with the latest master - any idea how to get it to use the correct tag please? - sorry for asking in here - no forum access)
That's how you can link (this is line 2 in main.cpp from current master): https://github.com/bitcoin/bitcoin/blob/master/src/main.cpp#L2
@sipa, the commit in question that introduced the code (which I maintain doesn't do what it says it does) is this: https://github.com/bitcoin/bitcoin/commit/0aa89c08ff271f34271e6fd2eb1ef04afdbcab3a