When converting user input the result is zero if the conversion fails. There should be a better error handling, especially in argument/config handling.
cc @laanwj
-
promag commented at 10:25 AM on December 14, 2017: member
-
MarcoFalke commented at 6:20 PM on December 14, 2017: member
This is already mentioned in the developer notes: https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md#strings-and-formatting
Please submit a pull request if the current code is not conformant.
- MarcoFalke closed this on Dec 14, 2017
-
promag commented at 6:25 PM on December 14, 2017: member
Such PR could be a complex refactor. One usage to fix is
GetArg(..., uint64_t). -
MarcoFalke commented at 6:31 PM on December 14, 2017: member
That, imo, should be solved by checking the command line args on init. C.f. #11819
- MarcoFalke locked this on Sep 8, 2021
Contributors