fees: Remove fallbackfee default #11918

1. 
   MarcoFalke commented at 5:53 pm on December 16, 2017: member

   fallbackfee is impossible to keep up-to-date by hardcoding a default value. This removes the default value and hands the responsibility to the user to determine an appropriate fallbackfee in case fee estimates are not available.

   Todo:

   • Properly rework the GUI when no fee estimates are available and no fallbackfee is set. (TBD: Upcoming in a later pull request)
2. fees: Remove fallbackfee default faad60ce97
3. MarcoFalke force-pushed on Dec 16, 2017
4. qa: Add fallbackfee no-default tests faa7577ceb
5. 
   aikq35 commented at 10:03 pm on December 16, 2017: none

   #11882
6. fanquake added the label TX fees and policy on Dec 16, 2017
7. fanquake added the label Wallet on Dec 16, 2017
8. MarcoFalke added the label Needs release notes on Dec 16, 2017
9. 
   laanwj commented at 9:29 am on December 20, 2017: member

   Concept ACK. I think this is is an obviously good idea. If no fee estimate can be made, users should set a manual fee. Hardcoding a fallback fee is not realistic anymore.
10. 
    promag commented at 9:35 am on December 20, 2017: member

    +1
11. 
    jonasschnelli commented at 6:30 pm on December 20, 2017: contributor

    Concept ACK… the only bothering thing is, that regtest mode gets quite useless without passing in a -fallbackfee… and for that reason #11882 (removes default fallbackfee on mainnet only) may make more sense.
12. 
    MarcoFalke commented at 6:38 pm on December 20, 2017: member

    My understanding is that regtest mode becomes more and more useless as the number of differences to mainnet increase. If we special case that on mainnet, there’d be no way to test other than running a mainnet node.

    Especially since we plan to rework the gui based on the fallback settings, it is important to be able to test in a non-mainnet setting.

13. 
    morcos commented at 7:15 pm on December 20, 2017: member

    @MarcoFalke But how do you avoid anyone doing manual regtest avoiding passing -fallbackfee every time they launch?
14. 
    MarcoFalke commented at 8:24 pm on December 20, 2017: member

    They could specify it in their bitcoin.conf, assuming that it exists. If no bitcoin.conf exists, the only way I see is by passing it in on the command line.
15. 
    MarcoFalke commented at 8:24 pm on December 20, 2017: member

    Closing, since #11882 is now similar and there is little value in keeping both open.
16. MarcoFalke closed this on Dec 20, 2017

    ---

17. MarcoFalke deleted the branch on Dec 20, 2017
18. sipa removed the label Needs release notes on Aug 14, 2018
19. MarcoFalke locked this on Dec 16, 2021

Contributors
MarcoFalke aikq35 laanwj promag jonasschnelli morcos

Labels
Wallet TX fees and policy