Don't show grids for address book and transaction tables #1193

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2012_05_nogridtables changing 3 files +24 −8

laanwj commented at 4:09 PM on May 4, 2012: member
This is a matter of taste, but IMO this looks less cluttered and more modern.

Before

After

Also:
- Add all actions that can be triggered with buttons to the context menu
- Hide delete action from context menu for receiving tab
- Move attributes that can be set in .ui file
- Shorten "Copy to Clipboard" on button to simply "Copy Address". Shorter and more clear.

Address book improvements

- Don't show grids for address book and transaction tables. This is a matter of taste, but IMO this looks less cluttered.
  Also do this for transaction table.
- Add all actions that can be triggered with buttons to the context menu
- Hide delete action from context menu for receiving tab

bc67700a0c

laanwj commented at 6:53 AM on May 5, 2012: member

Updated...
Diapolo commented at 9:16 AM on May 5, 2012: none

ACK to the code and visual changes!
Daminvar commented at 5:49 PM on May 6, 2012: none

I think it looks better with the grid lines. They should stay.
luke-jr commented at 9:49 PM on May 6, 2012: member

I don't see alternating tinted rows, so without the grid lines it's kindof hard to read sometimes...
sipa commented at 10:07 PM on May 6, 2012: member

@luke-jr screenshot?
luke-jr commented at 10:14 PM on May 6, 2012: member
grue0 commented at 12:18 AM on May 7, 2012: none

@Daminvar @luke-jr Agreed, it does look better with gridlines, but only the vertical ones. There's no need for horizontal gridlines because any one with decent eyes can tell the lines apart.
luke-jr commented at 12:20 AM on May 7, 2012: member

I think you confused vertical and horizontal...
grue0 commented at 12:25 AM on May 7, 2012: none

@luke-jr I want lines going up and down I do not want lines going left to right
luke-jr commented at 12:33 AM on May 7, 2012: member

Lines going left to right are needed, not up and down...
sipa commented at 12:37 AM on May 7, 2012: member

De gustibus et coloribus...
laanwj commented at 5:27 AM on May 7, 2012: member

Too much bikeshedding. This was supposed to be a simple non-controversial commit, not a discussion topic. I'm closing this, and re-submitting it without the grid change.
laanwj closed this on May 7, 2012
suprnurd referenced this in commit a11bd2c5ba on Dec 5, 2017
lateminer referenced this in commit 13368af2e8 on Jan 22, 2019
lateminer referenced this in commit f49b0309a0 on Dec 25, 2019
dexX7 referenced this in commit 65e8d5795f on Nov 23, 2020
DrahtBot locked this on Sep 8, 2021

Contributors