C.f. #11964
qa: Note on test order in test_runner #11965
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:Mf1712-qaTestRunnerOrder changing 1 files +2 −0-
MarcoFalke commented at 7:56 PM on December 20, 2017: member
- MarcoFalke added the label Tests on Dec 20, 2017
- MarcoFalke added the label Docs on Dec 20, 2017
- MarcoFalke force-pushed on Dec 20, 2017
- MarcoFalke force-pushed on Dec 20, 2017
-
promag commented at 10:21 AM on December 21, 2017: member
ACK fa2333f.
Nit, should new tests be added at the end of the run-time section or should there be an effort to keep them sorted?
-
thijstriemstra commented at 1:41 PM on December 21, 2017: none
I would clarify it a little more, e.g.
# Don't add tests below this comment to avoid merge conflicts # Put them in a location above this comment based on their approximate run-timeor maybe 'line' instead of 'comment'.
-
qa: Note on test order in test_runner fadf60e381
- MarcoFalke force-pushed on Dec 21, 2017
-
MarcoFalke commented at 3:59 PM on December 21, 2017: member
@promag Adding at the end of run-time sections doesn't help with merge conflict. Sorting by name would. Though, since we plan to rename the tests, I don't want to go in this direction. @thijstriemstra Reworked wording a bit.
-
jnewbery commented at 10:01 AM on January 3, 2018: member
utACK fadf60e381006aa27689971771e83426fb7c0daa
- MarcoFalke merged this on Jan 3, 2018
- MarcoFalke closed this on Jan 3, 2018
- MarcoFalke referenced this in commit d38d1a3e75 on Jan 3, 2018
- MarcoFalke deleted the branch on Jan 3, 2018
- PastaPastaPasta referenced this in commit 8c202017fa on Apr 3, 2020
- PastaPastaPasta referenced this in commit 0f937164eb on Apr 3, 2020
- ckti referenced this in commit cfac6ed677 on Mar 28, 2021
- DrahtBot locked this on Sep 8, 2021
Contributors