[Doc] Clarify the meaning of fee delta not being a fee rate in prioritisetransaction RPC #12007

pull janbraiins wants to merge 1 commits into bitcoin:master from braiins:master changing 1 files +1 −0

janbraiins commented at 11:05 AM on December 24, 2017: contributor

Hi,

I have faced some confusion among our developers considering this being a fee rate. Would you consider including this tiny doc update?

Best regards,

Jan Capek
[Doc] Clarify the meaning of fee delta not being a fee rate in prioritisetransaction RPC c198dc00e1
meshcollider commented at 11:07 AM on December 24, 2017: contributor

Seems like a sensible addition, nice first contribution thanks :)
fanquake added the label Docs on Dec 24, 2017
fanquake added the label RPC/REST/ZMQ on Dec 24, 2017
MarcoFalke commented at 11:17 AM on December 29, 2017: member

utACK c198dc00e1611b43d031920e7f9912fc25a359c3

in src/rpc/mining.cpp:243 in c198dc00e1

 239 | @@ -240,6 +240,7 @@ UniValue prioritisetransaction(const JSONRPCRequest& request)
 240 |              "2. dummy          (numeric, optional) API-Compatibility for previous API. Must be zero or null.\n"
 241 |              "                  DEPRECATED. For forward compatibility use named arguments and omit this parameter.\n"
 242 |              "3. fee_delta      (numeric, required) The fee value (in satoshis) to add (or subtract, if negative).\n"
 243 | +            "                  Note, that this value is not a fee rate. It is a value to modify absolute fee of the TX.\n"

promag commented at 4:13 PM on January 2, 2018:

Instead of adding a new line, how about improving the description above (which IMO would be enough)?

jnewbery commented at 5:09 PM on April 2, 2018: member

utACK c198dc00e1611b43d031920e7f9912fc25a359c3
MarcoFalke merged this on Apr 9, 2018
MarcoFalke closed this on Apr 9, 2018
MarcoFalke referenced this in commit cd8e45b4e7 on Apr 9, 2018
PastaPastaPasta referenced this in commit b74f94c62c on Jul 17, 2020
PastaPastaPasta referenced this in commit 814a62085c on Jul 17, 2020
PastaPastaPasta referenced this in commit 1ebe189282 on Jul 19, 2020
PastaPastaPasta referenced this in commit ea5c11abf2 on Jul 21, 2020
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels