changed cursor for selectable text on the about dialog to IBeamCursor... #1201

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:about-dialog changing 1 files +9 −3
  1. Diapolo commented at 9:31 AM on May 5, 2012: none
    • removed an an unused XML-tag
  2. laanwj commented at 10:04 AM on May 5, 2012: member

    textFormat is not an unused tag ! To reduce the surprise factor, always prefer an explicit text format (PlainText, RichText) to AutoText, especially when user-provided input is involved (not the case here but still...). This prevents bugs such as this: http://vigilance.fr/vulnerability/KDE-certificate-spoofing-via-KSSL-and-Rekonq-11028

  3. Diapolo commented at 10:07 AM on May 5, 2012: none

    Well the default displayed in Qt Designer is Qt::AutoText, so I'm sure this is default and need's not to be added then? Default values in the Designer are non bold and changed values / settings are bold in the right attribute pane.

    A I read your link ... well I guess there are more places, where there is the default of Qt:AutoText used, is that a problem then? I even think it is no problem in the about dialog, no?

  4. laanwj commented at 10:08 AM on May 5, 2012: member

    Check the diff. It was RichText, not AutoText. Just keep it there, it's not hurting anything.

  5. Diapolo commented at 10:12 AM on May 5, 2012: none

    Right and as the text is in no way formatted (only line-feeds), it's save to use the default I think. If that gets plainText or RichText does not matter in that place. Well I can revert, no problem, but do you really think this is an security issue here? I only changed to save us a few lines.

  6. laanwj commented at 10:16 AM on May 5, 2012: member

    Please just change it back. Saving lines in the xml files is not a goal, there's just no need to change it in the first place.

    Being explicit (and reducing potential uncertain behavior) is a goal. If you encounter AutoText in other (potentially risky) places, feel free to change it.

    "it's save to use the default I think" are very dangerous words in these times :)

  7. Diapolo commented at 10:54 AM on May 5, 2012: none

    Convinced :), will revert ...

  8. changed cursor for selectable text on the about dialog to IBeamCursor and removed an unused tag 7b74bd4928
  9. Diapolo commented at 10:57 AM on May 5, 2012: none

    Updated...

  10. laanwj referenced this in commit 46c08874aa on May 5, 2012
  11. laanwj merged this on May 5, 2012
  12. laanwj closed this on May 5, 2012

  13. coblee referenced this in commit c4624d1f74 on Jul 17, 2012
  14. suprnurd referenced this in commit 30da3f56a7 on Dec 5, 2017
  15. lateminer referenced this in commit 4c9168eba2 on Jan 22, 2019
  16. Bushstar referenced this in commit 86ad200957 on Feb 27, 2021
  17. DrahtBot locked this on Sep 8, 2021
Contributors

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-21 18:16 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me