[qt] change µBTC to bits #12035

jb55 commented at 4:09 PM on December 27, 2017: member

Now that we have bip176, change "µBTC" to the more colloquial "bits"

Sjors commented at 5:06 PM on December 27, 2017: member

I would suggest bits (µBTC), Bits (µBTC) or µBTC (bits), so more SI oriented folks don't need to Google "bits". Can you add some screenshots to see what this would look like in the UI?

Sjors commented at 5:06 PM on December 27, 2017: member

Also paging @jimmysong who opened this can of worms :-)

jimmysong commented at 5:18 PM on December 27, 2017: contributor

I would love if we can switch to bits, but not required. I understand if people don't want to change it.

jb55 commented at 7:33 PM on December 27, 2017: member

current pic: https://jb55.com/s/2fbb07812e2dd00b.png

I would suggest bits (µBTC), Bits (µBTC) or µBTC (bits), so more SI oriented folks don't need to Google "bits".

This information is still available in the tooltip via BitcoinUnits::description if needed

Can you add some screenshots to see what this would look like in the UI?

This isn't a quick fix like this change, and will require some reworking so that it shows bits instead of bits (µBTC) everywhere.

fanquake added the label GUI on Dec 27, 2017

Sjors commented at 10:46 AM on December 28, 2017: member

@jb55 you can actually drag & drop images onto Github, so they're inline.

There's more places where "bits" would appear, e.g. in the settings and as a dropdown in the send screen. If we go for bits (µBTC) that would probably look fine in a dropdown menu, but look terrible on the transactions screen. Whereas bits probably looks fine everywhere.

I remember the first time I saw the term "bits" in a wallet (Xapo). I found it very confusing, because I didn't know how many decimals it represents. I'm fine with switching to bits, but shouldn't assume all users are familiar with it. So it requires some education.

The easiest way to achieve a minimum level of education is to have two strings. Use the short version bits everywhere expect the dropdown menus, where you use the long string bits (µBTC). That would add a few lines of code to this PR, but nothing unsurmountable. Let me know if you need any pointers.

The tooltips are useful as well, but I don't think those appear over the dropdown menus.

jb55 force-pushed on Dec 28, 2017

jb55 commented at 2:30 PM on December 28, 2017: member

I've implemented your suggestion in af7f3c1ccafefd92603a5138a136a52f0c249fe9

Here's what it looks like:

dec28-061640

dec28-061628

dec28-061139

dec28-071931

Sjors commented at 4:40 PM on December 28, 2017: member

ACK af7f3c1c, but please squash.

[qt] change µBTC to bits

* Now that we have bip176, change "µBTC" to the more colloquial "bits"

* We retain the `µBTC (bits)` description in dropdowns and status bars.
  The more concise "bits" is used when appended to numbers.

Signed-off-by: William Casarin <jb55@jb55.com>

275b2eeed4

jb55 force-pushed on Dec 28, 2017

jb55 commented at 5:58 PM on December 28, 2017: member

Squashed in 275b2eeed4050d8797bf127e5abf171c050e182a

Sjors commented at 6:15 PM on December 28, 2017: member

Thanks, reACK 275b2ee.

laanwj commented at 10:30 AM on December 30, 2017: member

No opinion on this but at least you should update doc/bips.md when you do this.

bips: add bip176 (Bits Denomination)

For the implementation in #12035.
Note that this only applies to the QT GUI at this time.

Signed-off-by: William Casarin <jb55@jb55.com>

ebcee1de26

jb55 commented at 6:49 PM on December 30, 2017: member

@laanwj done in ebcee1de263ea21acfd79e92dc874de65c9bae9b

laanwj commented at 9:25 AM on January 3, 2018: member

Tested ACK ebcee1d

jonasschnelli commented at 8:15 AM on January 4, 2018: contributor

utACK ebcee1de263ea21acfd79e92dc874de65c9bae9b

jonasschnelli merged this on Jan 4, 2018

jonasschnelli closed this on Jan 4, 2018

jonasschnelli referenced this in commit eeb6d5271d on Jan 4, 2018

classesjack referenced this in commit f2fd3234c5 on Jan 12, 2018

hkjn referenced this in commit 121d305153 on Jan 13, 2018

HashUnlimited referenced this in commit 87e0cf29fb on Mar 15, 2018

lionello referenced this in commit 0d0251f181 on Nov 7, 2018

deadalnix referenced this in commit 1c4b1649e4 on Feb 18, 2020

ftrader referenced this in commit e915394df1 on Apr 16, 2020

DrahtBot locked this on Sep 8, 2021