Enable the ability to view a signed transaction in the wallet UI (in hex format) prior to sending #12044

issue crbx opened this issue on December 28, 2017
  1. crbx commented at 10:19 PM on December 28, 2017: none

    It would be extremely useful to be able to view or save a signed transaction generated via the Send UI, in hex format. While it is possible to generate and sign a raw transaction manually via the command line, using the wallet UI is much simpler and less error prone.

    This would be particularly helpful for users who are looking to trade airdrop coins back to BTC. Forks are derived from Bitcoin Core, however it's not possible to trust the forked code. So it would be great to be able to generate signed transactions from a permanently offline box running the forked version of Bitcoin Core. (Then the transaction can be copied to an online box and sent to the network via any web gateway, e.g.: https://bitcointalk.org/index.php?topic=1938621.0) Having this feature in Bitcoin Core would mean that future forks would include the new UI.

    Additionally, this functionality will be useful even just for Bitcoin Core. It would be nice to be able to fully compose and sign a transaction in the UI without having to be on the network.

    A little button to show the signed transaction in the Send confirmation dialog would be sufficient to implement this feature. (I'm assuming it's possible to get to the Send UI when the wallet is offline.)

    Looking into the code in SendCoinsDialog.ccp, it's not immediately clear to me where signing occurs. Perhaps it happens in prepareTransaction? https://github.com/bitcoin/bitcoin/blob/master/src/qt/sendcoinsdialog.cpp#L263 ...or later on in sendCoins? https://github.com/bitcoin/bitcoin/blob/master/src/qt/sendcoinsdialog.cpp#L363

  2. achow101 commented at 10:25 PM on December 28, 2017: member

    You can get the raw transaction hex by going to the transactions list, right clicking a transaction, and choosing "Copy raw transaction" (or something like that).

  3. fanquake added the label GUI on Dec 28, 2017
  4. crbx commented at 10:53 PM on December 28, 2017: none

    Oh that's great, thanks! I'll give that a try. I assume it's possible to get a transaction sent out while being offline.

    Having to "send" the transaction unnecessary / annoying, but it doesn't matter in any case since the box is permanently offline. Still, having the ability to view the signed transaction without having to actually send it would be nice, though I guess not absolutely necessary.

  5. MarcoFalke commented at 11:42 PM on December 28, 2017: member

    Also, note that there is a command line option to disable tx broadcast. Try bitcoin-qt -help

    On Dec 28, 2017 11:53 PM, "crbx" notifications@github.com wrote:

    Oh that's great, thanks! I'll give that a try. I assume it's possible to get a transaction sent out while being offline.

    Having to "send" the transaction unnecessary / annoying, but it doesn't matter in any case since the box is permanently offline. Still, having the ability to view the signed transaction without having to actually send it would be nice, though I guess not absolutely necessary.

    — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bitcoin/bitcoin/issues/12044#issuecomment-354370407, or mute the thread https://github.com/notifications/unsubscribe-auth/AGGmv_bxLhtRZS4Un3_Tzrwa1xeit_Edks5tFBvxgaJpZM4ROsU4 .

  6. crbx commented at 3:53 AM on December 29, 2017: none

    Ok, thanks. I think that should be: bitcoin-qt -walletbroadcast=0

  7. MarcoFalke commented at 10:20 AM on December 29, 2017: member

    I think this can be closed, now.

  8. MarcoFalke closed this on Dec 29, 2017

  9. MarcoFalke locked this on Sep 8, 2021
Labels

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-21 18:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me