small passphrasedialog update #1206

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:passphrasedialog changing 2 files +8 −8
  1. Diapolo commented at 4:31 PM on May 5, 2012: none
    • change dialog title to "Passphrase Dialog as that's better for distinction on Transifex
    • remove style-sheet for bold font and use default Qt Designer option for bold
    • remove capsLabel default text -> results in removal of a clear() in the source

    I tried to move the string, which is displayed when Caps Lock is active into the .ui file and use setVisible(true / false), but that resulted in layout jumping / small layout movements, which were rather ugly!

  2. luke-jr commented at 4:42 PM on May 6, 2012: member

    You're changing the constant MAX_PASSPHRASE_SIZE into a literal 1024. Better to leave it as before, IMO, so MAX_PASSPHRASE_SIZE can be updated easily.

  3. Diapolo commented at 7:22 PM on May 6, 2012: none

    @laanwj Do you agree with luke-jr on his suggestion? What about the other changes? I'm interested in a small integration of these little commits :).

  4. laanwj commented at 7:32 PM on May 6, 2012: member

    I agree with luke-jr here. Please don't try to fix things that are not broken :/ Constants are always better than magic values, even in the XML file.

    Focus on the things that this pull request fixes/improves, which is not clear to me.

  5. passphrasedialog: change dialog title to "Passphrase Dialog" / remove style-sheet for bold font and use Qt Designer option / remove an unused label default-text and remove an obsolete clear()' 52d4975825
  6. Diapolo commented at 8:14 PM on May 6, 2012: none

    Updated to do only minor changes, I think style-sheets should be avoided if there is a Qt Designer default option for that goal. And the removal of the capsLabel default text results in one string less to translate that is never used anyway and as result allows to remove a clear() in the code.

  7. laanwj referenced this in commit f93727aa56 on May 11, 2012
  8. laanwj merged this on May 11, 2012
  9. laanwj closed this on May 11, 2012

  10. coblee referenced this in commit 532f8096f9 on Jul 17, 2012
  11. suprnurd referenced this in commit 84c242fc8c on Dec 5, 2017
  12. lateminer referenced this in commit b106c1de5d on Jan 22, 2019
  13. lateminer referenced this in commit 66d4159b1d on Jan 22, 2019
  14. lateminer referenced this in commit 80414f9795 on Jan 10, 2020
  15. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-21 18:16 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me