[qt] Optimizes boolean expression model && model->haveWatchOnly() #12074

pull l2a5b1 wants to merge 1 commits into bitcoin:master from l2a5b1:patch/TransactionView-optimize-boolean-expression changing 1 files +1 −1

l2a5b1 commented at 12:44 AM on January 2, 2018: contributor

This PR optimizes the boolean expression model && model->haveWatchOnly() to model->haveWatchOnly().

The boolean expression can be optimized because the method TransactionView::exportClicked already guards against a potential dereferenced null pointer by returning early if model is null. https://github.com/bitcoin/bitcoin/blob/63a4dc10876bfc61c2e87d35dcf17da2f0f8c316/src/qt/transactionview.cpp#L351-L353

[qt] Simplifies boolean expression model && model->haveWatchOnly()

The boolean expression model && model->haveWatchOnly() can be simplified to model->haveWatchOnly(), because if (!model || !model->getOptionsModel()) { return; } guards against a potential dereferenced null pointer.

6dda059bde

dcousens approved
unknown approved
fanquake added the label GUI on Jan 2, 2018
promag commented at 2:15 AM on January 2, 2018: member

ACK 6dda059.
fanquake deleted a comment on Jan 2, 2018
MarcoFalke added the label Refactoring on Jan 2, 2018
jonasschnelli commented at 7:57 AM on January 4, 2018: contributor

utACK 6dda059bde0798f54626108beab29d9d3834769c
jonasschnelli merged this on Jan 4, 2018
jonasschnelli closed this on Jan 4, 2018
jonasschnelli referenced this in commit a1136f0cb4 on Jan 4, 2018
l2a5b1 deleted the branch on Jan 4, 2018
PastaPastaPasta referenced this in commit 1414729d19 on Jan 17, 2020
PastaPastaPasta referenced this in commit 15efe46dec on Jan 22, 2020
PastaPastaPasta referenced this in commit 0e2634f948 on Jan 22, 2020
PastaPastaPasta referenced this in commit 20edadace3 on Jan 29, 2020
PastaPastaPasta referenced this in commit c841555df3 on Jan 29, 2020
PastaPastaPasta referenced this in commit c3a1f928ea on Jan 29, 2020
PastaPastaPasta referenced this in commit 291051f209 on Jan 31, 2020
ckti referenced this in commit fcf7027e9b on Mar 28, 2021
DrahtBot locked this on Sep 8, 2021

Contributors

Labels