[qt] Replaces numbered place marker %2 with %1. #12092

pull l2a5b1 wants to merge 1 commits into bitcoin:master from l2a5b1:patch/12015/sendcoinsdialog-replaces-numbered-place-marker changing 1 files +1 −1
  1. l2a5b1 commented at 9:58 PM on January 4, 2018: contributor

    This PR closes #12015 in which @chen610620 suggests to replace numbered place marker %2 with %1.

    Calling member functionQString::arg() on a QString object with one arbitrary numbered place marker within the range [1,99] works, because QString::arg() replaces the lowest numbered place marker in the QString object it is called on.

    QString::arg documentation:

    Returns a copy of this string with the lowest numbered place marker replaced by string a, i.e., %1, %2, ..., %99.

    I suspect that the %2 marker is just an unfortunate typo or the remainder of a string that used to have multiple numbered place markers.

    This PR replaces the numbered place marker %2 with %1 to avoid any confusion in the future.

  2. Replaces numbered place marker %2 with %1.
    Replaces numbered place marker %2 with %1, because the QString::arg() member function is called once on the string used to create the QString object.
    8a93543419
  3. fanquake added the label GUI on Jan 4, 2018
  4. jb55 commented at 9:09 PM on January 5, 2018: member

    Tested ACK 8a93543419300bd78e189429e003c8b17c1b983a

  5. MarcoFalke commented at 9:37 PM on January 5, 2018: member

    Thanks. I missed this in 6dd3a44ce2cb4480054ae0ca0960f588a9ad8d25

    -----BEGIN PGP SIGNED MESSAGE-----
    Hash: SHA512
    
    utACK 8a93543419300bd78e189429e003c8b17c1b983a
    -----BEGIN PGP SIGNATURE-----
    
    iQIcBAEBCgAGBQJaT+/rAAoJENLqSFDnUoslzKgP/3KtG/W3eHfzfzWRDXGvCBeb
    TmGD4b3hEqMFz63Ns/6jptouuaHWz1T8YMX1Jgzj001Vr8BilbkiusQP1COsJQiA
    Xdqvlko811P8ES2SPQVOxD57lZttaSICQpykT0MI3HcWqEqZzLP1a0bWdQkW1Try
    DhQo2ycKZKKu1+5rZ/a8AAVnaz0gylQVjiosDKJlNp9jtl6/myc+M+cynSQMkmdR
    /2XNEnmPykimhNpdtOTDnr/fDo5X31UQuzWAAyuigOVv3V0DEfzO7WHLYetqwRbE
    oKcE/J8mZziN2Yz2EjGGM6PclcQ1C0E4XD99abIt5w9utbQoxrgdYcvGlGQtbrIx
    c/Da2x4Dw0Vmw80z8DbAG28/oFI1+3MhY2+bd0iO6k4bFq+AeklRcfRRaPbwtlfI
    zZNmYSucZp8WyiuqR3lwClQZejtRXfbQlYWj3rGotXIsYuAYJ5WalQUo4v8NNzbV
    ysKdbrmEgnWatYg252haXZTX6eQABtPfARySePT+GxR2RhBgH6km0FcAI0Qa+qif
    FVCO/FZu6320PZu34FmIQidGjJyn/Kk2PU+fblb63VtD2JNiP3dvyzPK5WtTP/km
    xNaXBhjl/iueW5TBJ8HS+mXyA6fIDvu6M6UZCoBhQKmzDDZTWCD7vdWkhtcLu9Wu
    jBfOLZDkNzAiG2TRvQ/K
    =IXGR
    -----END PGP SIGNATURE-----
    
  6. MarcoFalke merged this on Jan 5, 2018
  7. MarcoFalke closed this on Jan 5, 2018

  8. MarcoFalke referenced this in commit fd4ca17360 on Jan 5, 2018
  9. l2a5b1 deleted the branch on Feb 12, 2018
  10. jasonbcox referenced this in commit 2d6763dd0b on Sep 27, 2019
  11. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-21 18:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me