Unlock Wallet Implemented. #12149

pull kashyap2690 wants to merge 1 commits into bitcoin:master from BlockchainTechTeam:master changing 6 files +34 −1
  1. kashyap2690 commented at 11:51 AM on January 11, 2018: none

    For frequent operation which requires an unlocked wallet, use Unlock Wallet menu option for keeping the wallet unlocked till the application is running.

  2. Unlock Wallet Implemented. d9db6f20a6
  3. meshcollider commented at 11:59 AM on January 11, 2018: contributor

    Thanks for trying to contribute! Please give a description of the change you're making as well as the reason behind it when opening a pull request :) Also, check your spelling and formatting of the new code as per the developer guide

  4. laanwj added the label Wallet on Jan 11, 2018
  5. MarcoFalke added the label GUI on Jan 11, 2018
  6. kashyap2690 commented at 7:08 AM on January 12, 2018: none

    Updated the description.

  7. jonasschnelli commented at 8:03 AM on January 12, 2018: contributor

    Thanks for contributing.

    Not sure if this is a desirable concept (keeping the wallet unlocked for unlimited time)... especially not with informing the user about the possible consequences / ramification.

    Also, code wise, it seems to be a misuse of the RAII UnlockContext object. Please read the developer notes, the style guide, etc. Code seems misaligned and not confirming to the style guide.

  8. MarcoFalke commented at 1:20 AM on January 19, 2018: member

    Are you still working on this? Otherwise, I'd suggest to close.

  9. fanquake closed this on Jan 22, 2018

  10. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 18:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me