Make user actions more straightforward in address book #1215

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2012_05_nogridtables changing 2 files +25 −10

laanwj commented at 5:31 AM on May 7, 2012: member
- Add all actions that can be triggered with buttons to the context menu
- Hide delete action from context menu for receiving tab
- "Copy Address" instead of the vague, longwinded "Copy to Clipboard"
Diapolo commented at 8:45 AM on May 7, 2012: none

Could you add a Sign message button to the address book tab after the QR Code button to be in line with send coins and because you added it to the context menu?

I'm asking myself if it is allowed to use a non owned address to sign a message in general?
laanwj commented at 8:57 AM on May 7, 2012: member

Yeah I noticed that inconsistency too, however it is not a good idea any more buttons. We'll add future actions only to the context menu. See it like this: The context menu has the authoritative list of actions, the buttons are just there to shortcut a few common ones.

There are already various issues about the button row being to wide especially in verbose languages (#1062 is one of them). It would be possible to show only icons for the buttons, but that needs a new pull request. No more cosmetic changes in this one :)

And right, you cannot use a non-owned address to sign a message. That'd be kind of contrary to the idea of signing.

Make user action more straightforward in address book

- Add all actions that can be triggered with buttons to the context menu
- Hide delete action from context menu for receiving tab

356c3cad1a

in src/qt/addressbookpage.cpp:None in c6e97d8898 outdated

  80 | -    contextMenu->addAction(deleteAction);
  81 | +    if(tab != ReceivingTab)
  82 | +        contextMenu->addAction(deleteAction);
  83 | +    contextMenu->addSeparator();
  84 | +    contextMenu->addAction(showQRCodeAction);
  85 | +    contextMenu->addAction(signMessageAction);

Diapolo commented at 9:09 AM on May 7, 2012:

But you allow signing of non receiving addresses here, no?

laanwj commented at 9:14 AM on May 7, 2012:

Right, thanks for noticing

laanwj commented at 9:41 AM on May 7, 2012: member

Fixed
laanwj referenced this in commit 9e11cb53dd on May 9, 2012
laanwj merged this on May 9, 2012
laanwj closed this on May 9, 2012
coblee referenced this in commit a88100a8b4 on Jul 17, 2012
laanwj deleted the branch on Apr 9, 2014
lateminer referenced this in commit 8ac4c32ae4 on Jan 22, 2019
dexX7 referenced this in commit 5eb26d27f5 on Apr 8, 2021
DrahtBot locked this on Sep 8, 2021

Contributors

laanwj

Diapolo