std::string::find has a character based overload as can be seen here (4th oveload): http://www.cplusplus.com/reference/string/string/find/
Use that instead of constantly allocating temporary strings.
Use the character based overload for std::string::find. #12159
pull ghost wants to merge 1 commits into bitcoin:master from changing 5 files +15 −15-
ghost commented at 8:43 PM on January 11, 2018: none
-
a73aab7cd8
Use the character based overload for std::string::find.
std::string::find has a character based overload as can be seen here (4th oveload): http://www.cplusplus.com/reference/string/string/find/ Use that instead of constantly allocating temporary strings.
- fanquake added the label Refactoring on Jan 11, 2018
-
promag commented at 12:08 AM on January 18, 2018: member
utACK a73aab7 although I guess the difference is neglectable?
- dcousens approved
-
laanwj commented at 12:50 PM on January 29, 2018: member
utACK a73aab7cd8343d795b1a7408bd71f522262ac76e Seems like good practice to me to use the simpler overload where possible, though I wonder, too, if this really makes a difference in these places.
- laanwj merged this on Jan 29, 2018
- laanwj closed this on Jan 29, 2018
- laanwj referenced this in commit f3c7062b7b on Jan 29, 2018
- jasonbcox referenced this in commit c56fa16848 on Sep 13, 2019
- jonspock referenced this in commit 6a7187f9d7 on Dec 22, 2019
- proteanx referenced this in commit 9b891d0284 on Dec 23, 2019
- PastaPastaPasta referenced this in commit bac8ae306c on Jan 17, 2020
- PastaPastaPasta referenced this in commit 44d9c37ac7 on Jan 22, 2020
- PastaPastaPasta referenced this in commit aeb8a02164 on Jan 22, 2020
- PastaPastaPasta referenced this in commit bff90a75d6 on Jan 29, 2020
- PastaPastaPasta referenced this in commit 4c69e28764 on Jan 29, 2020
- PastaPastaPasta referenced this in commit 665ce911c0 on Jan 29, 2020
- PastaPastaPasta referenced this in commit 2f8888a86e on Jan 31, 2020
- ckti referenced this in commit 826c1ff1db on Mar 28, 2021
- furszy referenced this in commit 60d36292bc on Jul 26, 2021
- DrahtBot locked this on Sep 8, 2021
Labels