No description provided.
[TRIVIAL] Remove continue statement at the end of loop. #12181
pull ghost wants to merge 1 commits into bitcoin:master from changing 1 files +0 −1-
ghost commented at 5:17 PM on January 14, 2018: none
-
Remove continue statement at the end of loop. 6af7bc9b12
-
MarcoFalke commented at 9:41 PM on January 14, 2018: member
Tend to NACK here. This serves as documentation, indicating that the (large) scope is indeed the scope of a loop.
-
bolekC commented at 9:54 PM on January 14, 2018: none
Tend to agree with NACK. This code is anyway a bit too long so
continuecan help to read. -
ghost commented at 10:08 PM on January 14, 2018: none
I think a comment at the end of the scope might serve as better documentation ( // End while loop ). A continue does not provide this information IMHO.
-
MarcoFalke commented at 10:24 PM on January 14, 2018: member
A continue does not provide this information IMHO.
It does. It is even compile-time enforced documentation, in contrast to a comment, which easily gets outdated.
-
ghost commented at 10:32 PM on January 14, 2018: none
I'm indifferent to the outcome but it's not a compile-time enforced documentation. It's bikeshedding at this point.
-
MarcoFalke commented at 10:35 PM on January 14, 2018: member
heh, right. Better close it :)
- MarcoFalke closed this on Jan 14, 2018
-
bolekC commented at 10:36 PM on January 14, 2018: none
A continue does not provide this information IMHO.
It does. It is even compile-time enforced documentation, in contrast to a comment, which easily gets outdated.
Can you check if compiler generates the same code in both cases ?
-
MarcoFalke commented at 10:38 PM on January 14, 2018: member
I meant that the compiler will error out, if you place a
continueat the end of a random non-loop scope. - DrahtBot locked this on Sep 8, 2021
Contributors