Log debug build status and warn when running benchmarks #12197

laanwj commented at 10:51 AM on January 16, 2018: member

Log whether the starting instance of bitcoin core is a debug or release build (--enable-debug).

Also warn when running the benchmarks with a debug build, to prevent mistakes comparing debug to non-debug results.

Log debug build status and warn when running benchmarks

Log whether the starting instance of bitcoin core is a debug or release
build (--enable-debug).

Also warn when running the benchmarks with a debug build, to prevent
mistakes comparing debug to non-debug results.

0c74e2e890

laanwj added the label Utils/log/libs on Jan 16, 2018

in src/init.cpp:812 in 0c74e2e890 outdated

 807 | @@ -808,7 +808,13 @@ void InitLogging()
 808 |      fLogIPs = gArgs.GetBoolArg("-logips", DEFAULT_LOGIPS);
 809 |  
 810 |      LogPrintf("\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n");
 811 | -    LogPrintf("Bitcoin version %s\n", FormatFullVersion());
 812 | +    std::string version_string = FormatFullVersion();
 813 | +#ifdef DEBUG

laanwj commented at 11:00 AM on January 16, 2018:

Could move this into FormatFullVersion if we want it in all places where the version is printed, but I wasn't entirely sure about that being useful, the point is just to have this in the log for post-mortem analysis.

in src/init.cpp:813 in 0c74e2e890 outdated

 807 | @@ -808,7 +808,13 @@ void InitLogging()
 808 |      fLogIPs = gArgs.GetBoolArg("-logips", DEFAULT_LOGIPS);
 809 |  
 810 |      LogPrintf("\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n");
 811 | -    LogPrintf("Bitcoin version %s\n", FormatFullVersion());
 812 | +    std::string version_string = FormatFullVersion();
 813 | +#ifdef DEBUG
 814 | +    version_string += " (debug build)";

promag commented at 11:18 AM on January 16, 2018:

µNit:

#ifdef DEBUG
    const std::string version_string = FormatFullVersion() + " (debug build)";
#else
    const std::string version_string = FormatFullVersion() + " (release build)";
#endif

laanwj commented at 11:45 AM on January 16, 2018:

Meh, I prefer it this way.

promag commented at 11:19 AM on January 16, 2018: member

Concept ACK.

in src/init.cpp:817 in 0c74e2e890 outdated

 813 | +#ifdef DEBUG
 814 | +    version_string += " (debug build)";
 815 | +#else
 816 | +    version_string += " (release build)";
 817 | +#endif
 818 | +    LogPrintf("Bitcoin version %s\n", version_string);

MarcoFalke commented at 12:49 PM on January 16, 2018:

Should say "Bitcoin Core" according to the rebranding 4 years ago: #3408

laanwj commented at 6:14 PM on January 18, 2018:

I didn't introduce this message here, but sure, can update this.

laanwj commented at 6:29 PM on January 18, 2018:

I've changed it to use PACKAGE_NAME (which is Bitcoin Core), same as for the --help messages.

MarcoFalke commented at 9:45 PM on January 18, 2018: member

Will test after squash

laanwj force-pushed on Jan 19, 2018

Use PACKAGE_NAME instead of hardcoding application name in log message 34328b4980

laanwj force-pushed on Jan 19, 2018

MarcoFalke commented at 5:11 PM on January 23, 2018: member

Works for me:

./src/qt/bitcoin-qt -printtoconsole|grep "Bitcoin Core"
2018-01-23 17:08:21 Bitcoin Core version v0.15.99.0-a4057776c4-dirty (release build)

MarcoFalke commented at 7:03 PM on January 23, 2018: member

Note that gcc yells at me for compiling with _FORTIFY_SOURCE (default to on when hardening) and --enable-debug. So maybe we should disable hardening for debug builds, but that clearly is out of scope for this pull request.

laanwj merged this on Jan 29, 2018

laanwj closed this on Jan 29, 2018

laanwj referenced this in commit 000ac4fd01 on Jan 29, 2018

jasonbcox referenced this in commit 81c6819f38 on Dec 20, 2019

PastaPastaPasta referenced this in commit d26173fbcb on Jun 13, 2020

PastaPastaPasta referenced this in commit 73193c7e8c on Jun 13, 2020

PastaPastaPasta referenced this in commit cda702f451 on Jun 17, 2020

PastaPastaPasta referenced this in commit fa9fbbaab0 on Jun 18, 2020

gades referenced this in commit 65e484c5de on Jun 28, 2021

DrahtBot locked this on Sep 8, 2021