qa: Add missing syncwithvalidationinterfacequeue to tests #12217

1. 
   MarcoFalke commented at 3:06 pm on January 18, 2018: member

   Fixes intermittent travis failures with those tests caused by a missing flush of mempool txes to the wallet.
2. MarcoFalke added the label Tests on Jan 18, 2018
3. MarcoFalke force-pushed on Jan 18, 2018
4. in test/functional/mempool_persist.py:73 in fa838c4063 outdated

   72         self.start_node(2)
   73         # Give bitcoind a second to reload the mempool
   74-        time.sleep(1)
   75-        wait_until(lambda: len(self.nodes[0].getrawmempool()) == 5)
   76-        wait_until(lambda: len(self.nodes[2].getrawmempool()) == 5)
   77+        wait_until(lambda: len(self.nodes[0].getrawmempool()) == 5, timeout=1)
   

   ---

   ---

   

   promag commented at 5:29 pm on January 18, 2018:

   Use sync_mempool with nodes 0 and 2?

   ---

   

   MarcoFalke commented at 9:13 pm on January 18, 2018:

   We don’t want to sync_mempools, but check that there are exactly 5 txs in the mempool. (Hopefully the ones that were there on shutdown)
5. 
   promag commented at 5:29 pm on January 18, 2018: member

   utACK fa838c4.
6. qa: Add missing syncwithvalidationinterfacequeue to tests fa796bb695
7. in test/functional/zapwallettxes.py:65 in fa838c4063 outdated

   58@@ -59,6 +59,7 @@ def run_test(self):
   59         self.start_node(0, ["-persistmempool=1", "-zapwallettxes=2"])
   60 
   61         wait_until(lambda: self.nodes[0].getmempoolinfo()['size'] == 1, timeout=3)
   62+        self.nodes[0].syncwithvalidationinterfacequeue()  # Flush mempool to wallet
   63 
   64         assert_equal(self.nodes[0].gettransaction(txid1)['txid'], txid1)
   65         assert_equal(self.nodes[0].gettransaction(txid2)['txid'], txid2)
   

   ---

   ---

   

   MarcoFalke commented at 2:24 pm on January 19, 2018:

   For the reviewer, the issue that it fixes here is: JSONRPCException: Invalid or non-wallet transaction id (-5)

   I remember that we saw those on travis, but I fail to locate a log with that error.

8. MarcoFalke force-pushed on Jan 25, 2018
9. MarcoFalke force-pushed on Jan 25, 2018
10. 
    MarcoFalke commented at 3:32 pm on January 25, 2018: member

    Rebased
11. 
    laanwj commented at 9:56 am on January 29, 2018: member

    utACK fa796bb695797810b90c7b6016fd4e9a1890f016
12. laanwj merged this on Jan 29, 2018
13. laanwj closed this on Jan 29, 2018

    ---

14. laanwj referenced this in commit 1213be6c3a on Jan 29, 2018
15. MarcoFalke deleted the branch on Jan 29, 2018
16. MarcoFalke referenced this in commit e2d36639ca on Mar 12, 2020
17. sidhujag referenced this in commit b5531960ba on Mar 13, 2020
18. PastaPastaPasta referenced this in commit d7732b0bc8 on Jun 13, 2020
19. PastaPastaPasta referenced this in commit 52fc5a6be8 on Jun 13, 2020
20. PastaPastaPasta referenced this in commit fac5e4a18e on Jun 17, 2020
21. PastaPastaPasta referenced this in commit ab07a468b0 on Jun 18, 2020
22. sidhujag referenced this in commit e8599a1feb on Nov 10, 2020
23. PastaPastaPasta referenced this in commit 39136e6c43 on Jun 27, 2021
24. PastaPastaPasta referenced this in commit d6fadb28bb on Jun 28, 2021
25. PastaPastaPasta referenced this in commit 35bb03740e on Jun 29, 2021
26. PastaPastaPasta referenced this in commit 785e7b99ff on Jul 1, 2021
27. PastaPastaPasta referenced this in commit b8676ddc7d on Jul 1, 2021
28. DrahtBot locked this on Sep 8, 2021

Contributors
MarcoFalke promag laanwj

Labels
Tests