More granular net logging #12219

1. 
   laanwj commented at 4:49 pm on January 18, 2018: member

   #11583 moved many network logging messages to the net category, including the version messages for new connections.

   I think this was a good idea in itself, however this means that the only way to get information about connections and abnormal things happening is to enable all network logging. This includes every single message and transaction, bogs down performance and fills up the disk quickly.

   I’d like a category for just low-traffic network logging.

2. laanwj added the label P2P on Jan 18, 2018
3. laanwj added the label Utils/log/libs on Jan 18, 2018
4. 
   jnewbery commented at 4:57 pm on January 18, 2018: member

   I agree, and at the risk of scope creep, It’d be nice to have log levels for all logs (eg CRITICAL, ERROR, WARNING, INFO, DEBUG) and be able to filter logs level for all categories independently.
5. 
   laanwj commented at 5:02 pm on January 18, 2018: member

   Yes, I like that solution, certainly in the long run. Connection/disconnection/misbehavior events could then have INFO priority, while the mish-mash of individual messages would only be logged at DEBUG. This creates a Cartesian product of category × level, the same as in many other applications that log. I’ve proposed it before in an IRC meeting but no one liked it at the time, happy to get some support :)
6. 
   donaloconnor commented at 8:04 pm on January 18, 2018: contributor

   +1

   Agreed on the log levels concept. This is pretty standard across my experience. It also makes log viewer programs easy to work with (eg BareTail) by creating filters/colour coded output. This is a bit out of scope of this issue though.

7. laanwj referenced this in commit 9a32114626 on Feb 6, 2018
8. PastaPastaPasta referenced this in commit 3564993bcb on Jan 26, 2020
9. PastaPastaPasta referenced this in commit 49549390af on Jan 27, 2020
10. ckti referenced this in commit 06219ebcd0 on Mar 28, 2021
11. gades referenced this in commit cc58c89ce1 on Feb 22, 2022
12. 
    laanwj commented at 6:57 am on April 14, 2022: member

    I’m going to close this in favor of adding verbosity levels to logging (#24464). This is a more general solution that can achieve the same goal.
13. laanwj closed this on Apr 14, 2022

    ---

14. 
    jonatack commented at 7:01 am on April 14, 2022: member

    I’d like a category for just low-traffic network logging.

    Agree!

15. DrahtBot locked this on Apr 14, 2023

Contributors
laanwj jnewbery donaloconnor jonatack

Labels
P2P Utils/log/libs