After this change key-value pairs of the bytessent_per_msg and bytesrecv_per_msg are pushed unconditionally. Obviously this makes the object larger (with some values always equal to zero), but avoids some KeyErrors on common values such as "pong", e.g. when a pong was not yet received.
rpc: Avoid KeyError in getpeerinfo bytes per msg #12231
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:Mf1801-rpcPeerInfoKeyError changing 2 files +5 −5-
MarcoFalke commented at 10:38 PM on January 19, 2018: member
-
rpc: Avoid KeyError in getpeerinfo bytes per msg fadb8ad9cc
- MarcoFalke added the label RPC/REST/ZMQ on Jan 19, 2018
-
laanwj commented at 8:14 AM on January 20, 2018: member
I'd prefer changing the test code to changing the interface, personally. I like the current compact format.
- MarcoFalke closed this on Jan 20, 2018
- MarcoFalke deleted the branch on Jan 20, 2018
- DrahtBot locked this on Sep 8, 2021
Contributors
Labels