Bitcoin segwit address accepts litecoin segwit transaction #12301

<!-- This issue tracker is only for technical issues related to Bitcoin Core. General bitcoin questions and/or support requests are best directed to the Bitcoin StackExchange at https://bitcoin.stackexchange.com. For reporting security issues, please read instructions at https://bitcoincore.org/en/contact/. If the node is "stuck" during sync or giving "block checksum mismatch" errors, please ensure your hardware is stable by running memtest and observe CPU temperature with a load-test tool such as linpack before creating an issue! -->

Describe the issue

As a test, I withdrew litecoin to a Bitcoin core generated segwit address. I used a Yobit wallet for this test. The withdrawal went through and now sits in a litecoin address I have no private key of

What behavior did you expect?

I would expect the transaction to bounce, since it's generated from a Bitcoin address

What was the actual behavior?

The transferred litecoin now sits in what originally was a Bitcoin address

<!--- How reliably can you reproduce the issue, what are the steps to do so? -->

<!-- What version of Bitcoin Core are you using, where did you get it (website, self-compiled, etc)? -->

<!-- What type of machine are you observing the error on (OS/CPU and disk type)? -->

<!-- Any extra information that might be useful in the debugging process. -->

<!--- This is normally the contents of a `debug.log` or `config.log` file. Raw text or a link to a pastebin type site are preferred. -->

This is a problem with the sending wallet, it should check the address prefix against the litecoin one. Bitcoin core cannot "bounce" altcoin transactions as it has no access to that chain.

WalterBoles, I bought some litecoin on the exchange and withdrew it to a Bitcoin core segwit address. On chain.so, I can see the amount sitting in the same litecoin segwit address as the address I generated on the Bitcoin core wallet.

I assume you are using P2SH, in which case you should report the issue to the litecoin wallet developers and the exchange (i.e. sending wallet) that sent the coins to you.

Apparently they use the same "chain identifier" (i.e. version) for base58 p2sh addresses. See ltc and btc

Litecoin wallets should not generate nor accept such addresses. The issue is clearly with their software.

Thanks for clarifying! Deferred it to the litecoin repo.