QT ignores -changetype=bech32 when coin control features are enabled #12312

1. 
   Sjors commented at 3:35 PM on January 31, 2018: member

   Steps to reproduce:

   1. put changetype=bech32 in bitcoin.conf or launch QT with -changetype=bech32

   2. send money to any legacy address

   3. use decoderawtransaction to see that the change address is bech32, as expected since #12119

   4. enable Coin Control in settings menu

   5. send money to any legacy address

   6. use decoderawtransaction to see that the change address is now p2sh-segwit

2. 
   instagibbs commented at 4:20 PM on January 31, 2018: member

   my guess without reading the code is that coin control in QT basically "over-rides" whatever coin control was set to at startup. I wonder how many other settings get wiped too...

3. 
   promag commented at 4:39 PM on January 31, 2018: member

   IIUC the problem is the coin control of the dialog is statically instanced and the arguments are not yet processed, submitting a fix.

4. MarcoFalke added this to the milestone 0.16.0 on Jan 31, 2018
5. MarcoFalke added the label GUI on Jan 31, 2018
6. 
   jonasschnelli commented at 7:12 PM on February 1, 2018: contributor

   @Sjors: can you confirm that #12327 does fix the problem (and maybe review it)?

7. jonasschnelli closed this on Feb 1, 2018

   ---

8. jonasschnelli referenced this in commit 41363fe11d on Feb 1, 2018
9. 
   Sjors commented at 8:06 PM on February 1, 2018: member

   @jonasschnelli confirmed.

10. PastaPastaPasta referenced this in commit b2af19b664 on Apr 4, 2020
11. PastaPastaPasta referenced this in commit 625142bfa0 on Apr 5, 2020
12. ckti referenced this in commit 0f5f6537b8 on Mar 28, 2021
13. MarcoFalke locked this on Sep 8, 2021
14. gades referenced this in commit cd9da49e17 on Feb 16, 2022

Milestone
0.16.0