qt: Make sure splash screen is freed on AppInitMain fail #12374

1. 
   laanwj commented at 9:34 am on February 7, 2018: member

   The splashFinished event was never sent if AppInitMain fails, causing the splash screen to stick around, causing problems later.

   This bug has existed for a while but is now trigging potential crashed because the splash screen subscribes to wallet events.

   Meant to fix #12372.

2. laanwj added the label GUI on Feb 7, 2018
3. laanwj added the label Needs backport on Feb 7, 2018
4. laanwj added this to the milestone 0.16.0 on Feb 7, 2018
5. qt: Make sure splash screen is freed on AppInitMain fail

   The `splashFinished` event was never sent if AppInitMain fails,
   causing the splash screen to stick around, causing problems
   later.
   
   This bug has existed for a while but is now trigging potential crashed
   because the splash screen subscribes to wallet events.
   
   Meant to fix #12372.
   
   Signed-off-by: Wladimir J. van der Laan <laanwj@gmail.com>

   f5a4c3ddf4
6. qt: Clarify some comments

   Signed-off-by: Wladimir J. van der Laan <laanwj@gmail.com>

   1e5d14b3f7
7. laanwj force-pushed on Feb 7, 2018
8. 
   jonasschnelli commented at 6:25 pm on February 7, 2018: contributor

   Thanks! utACK 1e5d14b3
9. 
   promag commented at 6:45 pm on February 7, 2018: member

   utACK 1e5d14b.
10. 
    meshcollider commented at 9:45 pm on February 7, 2018: contributor

    utACK https://github.com/bitcoin/bitcoin/pull/12374/commits/1e5d14b3f7db814505279d346f0b819443753e66
11. laanwj merged this on Feb 8, 2018
12. laanwj closed this on Feb 8, 2018

    ---

13. laanwj referenced this in commit 11f3eac793 on Feb 8, 2018
14. laanwj referenced this in commit daaae36e15 on Feb 8, 2018
15. laanwj referenced this in commit dafd0078a2 on Feb 8, 2018
16. laanwj removed the label Needs backport on Feb 8, 2018
17. HashUnlimited referenced this in commit 8cbba5006d on Mar 16, 2018
18. HashUnlimited referenced this in commit b1235f0394 on Mar 16, 2018
19. ccebrecos referenced this in commit 81a1379193 on Sep 14, 2018
20. ccebrecos referenced this in commit 3af0ba38fe on Sep 14, 2018
21. PastaPastaPasta referenced this in commit 5ed53ff93c on Mar 14, 2020
22. PastaPastaPasta referenced this in commit 61bd9bdc6b on Mar 14, 2020
23. PastaPastaPasta referenced this in commit aa34483efd on Mar 15, 2020
24. ckti referenced this in commit 1d72660574 on Mar 28, 2021
25. DrahtBot locked this on Sep 8, 2021

Contributors
laanwj jonasschnelli promag meshcollider

Labels
GUI

Milestone
0.16.0