The shutdown process has started in requestShutdown, but initialize will happily continue with initializeResult and start threads late in the shutdown progess. Deleting this running thread will crash the application according to the qt docs:
https://github.com/qt/qtbase/blob/e5033a5c9b769815112e922d0b224af860afd219/src/corelib/thread/qthread.cpp#L412-L415
Potential fix for #12372 (comment)
This reverts #11831 for now and hopefully restores the previous behaviour.
466@@ -467,8 +467,7 @@ void BitcoinApplication::initializeResult(bool success)
467 qDebug() << __func__ << ": Initialization result: " << success;
468 // Set exit result.
469 returnValue = success ? EXIT_SUCCESS : EXIT_FAILURE;
470- if(success)
471- {
472+ if (success && !ShutdownRequested()) {
appInitMain. The return value of appInitMain (“success”) is supposed to be false when shutdown was requested during initialization.
AppInitMain() returns and when this slot is executed, it’s a QueuedConnection.
Maybe
0diff --git a/src/init.cpp b/src/init.cpp
1index 50643ff96b..1f46e5e3d2 100644
2--- a/src/init.cpp
3+++ b/src/init.cpp
4@@ -1736,5 +1736,5 @@ bool AppInitMain()
5 StartWallets(scheduler);
6 #endif
7
8- return true;
9+ return !ShutdownRequested();
10 }
It can make a difference if shutdown is requested between AppInitMain() returns and when this slot is executed, it’s a QueuedConnection.
Then after AppInitMain was successfully executed, a shutdown was requested (but not yet acted on), so I don’t understand why going into qt initialization would crash. It could successfully shutdown after that.
But anyhow if this fixes a reproducible issue I’m okay with it, it’s possible that there are interactions I don’t follow.
so I don’t understand why going into qt initialization would crash
That’s why I think this doesn’t fix the problem, just avoids it.
If you have means to reproduce the underlying issue, what might also work is moving the shutdown detection to only start after the GUI side of the initialization. E.g. move
0 pollShutdownTimer->start(200);
from BitcoinApplication::createWindow to BitcoinApplication::initializeResult (in the if(success)). This makes sure that no special action is undertaken if request shutdown is detected while initialization and avoids the race.
