travis: Full clone for git subtree check #12405

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:Mf1802-travisSubtree changing 1 files +2 −1

MarcoFalke commented at 2:15 PM on February 10, 2018: member

Lazy workaround and fix for #12388
MarcoFalke added the label Tests on Feb 10, 2018
MarcoFalke added this to the milestone 0.16.1 on Feb 11, 2018
laanwj commented at 2:56 PM on February 15, 2018: member

I disagree with this solution in the long run, but I'm going to cherry-pick this to the 0.16 branch to make travis pass there again.
travis: Full clone for git subtree check fa44af5cd2
MarcoFalke force-pushed on Feb 15, 2018
MarcoFalke removed this from the milestone 0.16.1 on Feb 15, 2018
MarcoFalke commented at 4:59 PM on February 16, 2018: member

I think it is a waste of time to micro-optimize travis solely for a questionable speedup. Note that the remote could be the bottleneck as well while counting and compressing the git objects. The runtime that travis reports for this commit/pull is 10.93s whereas on current master it is 12.95s.
MarcoFalke commented at 6:04 PM on March 7, 2018: member

Anything holding this back?
MarcoFalke merged this on Mar 13, 2018
MarcoFalke closed this on Mar 13, 2018
MarcoFalke referenced this in commit 0f58d7f3d6 on Mar 13, 2018
MarcoFalke deleted the branch on Mar 13, 2018
meshcollider commented at 8:50 PM on March 13, 2018: contributor

Post merge utACK https://github.com/bitcoin/bitcoin/commit/fa44af5cd2152a21da9ef3e48c073a668bf2df27
laanwj referenced this in commit 9f04c8e231 on Mar 14, 2018
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#12388 travis failure on rc3: "src/crypto/ctaes is not a subtree"#12682 travis: Clone depth 1 unless $CHECK_DOC